Skip to content

rename JULIA_HOME => Sys.BINDIR #25102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 18, 2017
Merged

rename JULIA_HOME => Sys.BINDIR #25102

merged 3 commits into from
Dec 18, 2017

Conversation

@StefanKarpinski
Copy link
Member

@StefanKarpinski StefanKarpinski commented Dec 15, 2017

No description provided.

@StefanKarpinski StefanKarpinski changed the title rename JULIA_HOME/JULIA_HOME => JULIA_BINDIR/Sys.BINDIR [#20899] rename JULIA_HOME => Sys.BINDIR Dec 16, 2017
ararslan
ararslan reviewed Dec 16, 2017
View reviewed changes
contrib/mac/juliarc.jl Outdated
ROOT = abspath(JULIA_HOME,"..")
ENV["PATH"]="$JULIA_HOME:$(ENV["PATH"])"
ROOT = abspath(Sys.BINDIR,"..")
ENV["PATH"]="$Sys.BINDIR:$(ENV["PATH"])"
Copy link
Member

@ararslan ararslan Dec 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The interpolation here will get Sys but not BINDIR; you'll need to put parentheses around Sys.BINDIR.

@StefanKarpinski StefanKarpinski force-pushed the sk/home branch 2 times, most recently from 1927dc4 to d031439 Compare December 16, 2017 18:52
@StefanKarpinski
Copy link
Member Author

StefanKarpinski commented Dec 16, 2017

This is pretty messy. I cannot figure out how to get deprecation from Base into Sys.Base to play nicely with the these changes. So this prints lots of "precompile might be broken" warnings during CI. @vtjnash, any ideas how to do this better? I've tried every combination of eval and placement I can think of.

@StefanKarpinski
Copy link
Member Author

StefanKarpinski commented Dec 17, 2017

Ok, screw the deprecations on this what – what a mess. The change itself is easy, making the deprecations not barf in all circumstances seems to be impossible, so I'm just not going to bother.

ararslan
ararslan reviewed Dec 17, 2017
View reviewed changes
base/deprecated.jl Outdated
deprecate(m::Module, s::Symbol, flag=1) = ccall(:jl_deprecate_binding, Void, (Any, Any, Cint), m, s, flag)

macro deprecate_binding(old, new, export_old=true, dep_message=nothing)
dep_message == nothing && (dep_message = ", use $new instead")
Copy link
Member

@ararslan ararslan Dec 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, the elusive 5 space indent...

@ararslan
Copy link
Member

ararslan commented Dec 17, 2017

Seems like you should be able to do the renaming and all of that, then just add a @deprecate_binding? Not sure though.

@StefanKarpinski
Copy link
Member Author

StefanKarpinski commented Dec 17, 2017

You would think so. But the combination of how this relates to code loading – variable definitions need to happen at a very particular point in the loading process – and the fact that the variable is not just moved inside of Base but moved into another module makes this a nightmare. There may be a way to do it, but I've already wasted enough time on this.

@ararslan
Copy link
Member

ararslan commented Dec 17, 2017

LGTM apart from the one 5-space indent. Nice work and thanks for going through it!

@StefanKarpinski
Copy link
Member Author

StefanKarpinski commented Dec 18, 2017

Why did someone cancel the Circle CI run?

@StefanKarpinski
@deprecate_binding: print the new binding by default
d48b9a4
@StefanKarpinski
capitalize Sys.CPU_NAME
43eee7f 
This was the only value exported from Sys with a lowercase name –
all other lowercase exports are functions and values are uppercase.
@StefanKarpinski
rename JULIA_HOME => Sys.BINDIR [fix #20899]
e83ce4b 
ENV["JULIA_HOME"] => ENV["JULIA_BINDIR"]
@StefanKarpinski StefanKarpinski merged commit 3cae287 into master Dec 18, 2017
@StefanKarpinski StefanKarpinski deleted the sk/home branch December 18, 2017 07:21
@fredrikekre fredrikekre mentioned this pull request Dec 18, 2017
Merged
@rdeits rdeits mentioned this pull request Dec 19, 2017
Merged
@omus omus mentioned this pull request Jan 1, 2018
Merged
@willow-ahrens willow-ahrens mentioned this pull request Jan 8, 2018
Closed
Keno pushed a commit that referenced this pull request Jun 5, 2024
@StefanKarpinski
Merge pull request #25102 from JuliaLang/sk/home
c4b3a38 
rename JULIA_HOME => Sys.BINDIR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ararslan ararslan ararslan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StefanKarpinski @ararslan