Skip to content

Rename remove_destination to force in cp, mv, and cptree #26069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2018
Merged

Rename remove_destination to force in cp, mv, and cptree #26069

merged 1 commit into from
Feb 16, 2018

Conversation

@ararslan
Copy link
Member

@ararslan ararslan commented Feb 15, 2018

Fixes #25979.

@ararslan ararslan added deprecation This change introduces or involves a deprecation filesystem Underlying file system and functions that use it labels Feb 15, 2018
@ararslan ararslan added this to the 1.0 milestone Feb 15, 2018
@StefanKarpinski
Copy link
Member

StefanKarpinski commented Feb 15, 2018 •
edited
Loading

Beautiful. How about renaming the follow_symlinks keyword on cp to symlinks while you're at it?

@JeffBezanson
Copy link
Member

JeffBezanson commented Feb 15, 2018

Let's merge this first. It's not super clear to me what symlinks=true would mean.

@StefanKarpinski
Copy link
Member

StefanKarpinski commented Feb 16, 2018

Think of it as short for “symlinks motherf@?&3r, do you follow them?”

@JeffBezanson JeffBezanson merged commit 1f20d1e into master Feb 16, 2018
@JeffBezanson JeffBezanson deleted the aa/force branch February 16, 2018 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JeffBezanson JeffBezanson JeffBezanson approved these changes

Assignees

No one assigned

Labels

deprecation This change introduces or involves a deprecation filesystem Underlying file system and functions that use it

Projects

None yet

Milestone

0.7

Development

Successfully merging this pull request may close these issues.

4 participants

@ararslan @StefanKarpinski @JeffBezanson