-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Fix docs for isdefined #18345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix docs for isdefined #18345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
base/docs/helpdb/Base.jl
Outdated
| Tests whether an assignable location is defined. The arguments can be a module and a symbol, | ||
| a composite object and field name (as a symbol), or an array and index. With a single | ||
| symbol argument, tests whether a global variable with that name is defined in | ||
| a composite object and field name (as a symbol) or index, or an Array and index. |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code quote Array ?
bf1b993 to
b848c3a
Compare
Member
Author
|
Pretty sure that Travis error is not related to this PR... |
b848c3a to
9033dff
Compare
doc/stdlib/base.rst
Outdated
| .. Docstring generated from Julia source | ||
| Tests whether an assignable location is defined. The arguments can be a module and a symbol, a composite object and field name (as a symbol), or an array and index. With a single symbol argument, tests whether a global variable with that name is defined in ``current_module()``\ . | ||
| Tests whether an assignable location is defined. The arguments can be a module and a symbol, a composite object and field name (as a symbol) or index, or an Array and index. With a single symbol argument, tests whether a global variable with that name is defined in ``current_module()``\ . |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing a genstdlib run here?
9033dff to
00cb3f7
Compare
Contributor
|
lgtm now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isdefined(object, index::Int)is implemented but was not documentedisdefined(a::AbstractArray, index::Int)was wrong in the sense thatisdefineddoes something different for Arrays than AbstractArrays.isassignedwith arrays, sinceisdefineddoesn't do the expected thing for AbstractArrays.