inline string literals in dot calls #19829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Test failure is an inference thing. Boils down to: julia> Base.REPLCompletions.get_type(:([""] .== ""), Main)
(Any,false)when it should give |
Member
Author
|
Since the |
…o handle dot calls now that they generate anonymous functions
stevengj
force-pushed
the
inlinestrings
branch
from
a1e221c to
7416eef
Compare
tkelman
reviewed
Jan 7, 2017
test/replcompletions.jl
Outdated
| # powerful enough to analyze general dot calls because it can't handle | ||
| # anonymous-function evaluation.) | ||
| # s = "CompletionFoo.test5(push!(Base.split(\"\",' '),\"\",\"\").==\"\"," | ||
| # c, r, res = test_complete(s) |
Contributor
There was a problem hiding this comment.
does this error or should these be @test_broken ?
Member
Author
There was a problem hiding this comment.
Right, I forgot about the @test_broken macro.
Member
Author
|
Okay to merge? |
Contributor
|
Can we test that is really being inlined? As in here |
Member
Author
|
Added a test for inlining. |
Member
Author
|
Ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a small optimization to inline string literals in dot calls. i.e.
f.("foo", bar)becomesbroadcast(x -> f("foo", x), bar)rather thanbroadcast((y,x) -> f(y, x), "foo", bar). In a small benchmark of["a" for i = 1:1000] .* "b", it led to about a 50% speedup.