Cleanup functions using DateLocale #21011
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions in Base.Dates that using
DateLocaletypically supported either taking aDateLocaleinstance or a string. Typically this meant that functions would use the type-assertionUnion{DateLocale, String}which made the function signatures really long and needed to be wrapped. I've made the type aliasLocaleto make these function signatures more readable.Additionally, the
formatfunction was updated to support allTimeTypesubtypes and not justDateandDateTime.