Rename split keyword from keep to keepempty #26647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a much clearer name. I've also enabled various forms of split/rsplit to be consistent with the docs.
fredrikekre
approved these changes
Mar 28, 2018
Member
fredrikekre
left a comment
fredrikekre
left a comment
There was a problem hiding this comment.
Should also leave a note in deprecated.jl so we remember to remove these deprecations.
JeffBezanson
approved these changes
Mar 28, 2018
jipolanco
added a commit
to JuliaVTK/WriteVTK.jl
that referenced
this pull request
Jun 5, 2018
Keno
pushed a commit
that referenced
this pull request
Jun 5, 2024
This is a much clearer name. I've also enabled various forms of split/rsplit to be consistent with the docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed in #26634