Skip to content

win10,tty: revert support for ANSI code passthrough #28314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 28, 2018
Merged

win10,tty: revert support for ANSI code passthrough #28314

merged 2 commits into from
Jul 28, 2018

Conversation

@vtjnash
Copy link
Member

@vtjnash vtjnash commented Jul 27, 2018

This fixes our regression with printing utf-8 characters to the windows terminal

vtjnash added 2 commits July 27, 2018 18:35
@vtjnash
win10,tty: revert support for ANSI code passthrough
a096c80 
fixes #27267
fixes #26894

We are not using this code now, so it is not important to keep active
for us right now. In the future, we should look into fixing these
bugs locally and filing an upstream bug report for it.
@vtjnash
win64-debug: relax 32-bit reservation requirement
92e0417 
I've been encountering this assertion consistently now on recent versions of Windows 10, so make it non-fatal as it is not essential.
@vtjnash vtjnash added system:windows Affects only Windows io Involving the I/O subsystem: libuv, read, write, etc. bugfix This change fixes an existing bug labels Jul 27, 2018
@JeffBezanson JeffBezanson added this to the 0.7 milestone Jul 27, 2018
@JeffBezanson
Copy link
Member

JeffBezanson commented Jul 27, 2018

@alkorang Can you confirm that this fixes the problem?

@yeonsookimdev
Copy link
Contributor

yeonsookimdev commented Jul 28, 2018

@vtjnash @JeffBezanson Great! This fixes the problem.

@yeonsookimdev yeonsookimdev mentioned this pull request Jul 28, 2018
Closed
@ararslan ararslan mentioned this pull request Jul 28, 2018
Merged
13 tasks
@JeffBezanson JeffBezanson merged commit 505f719 into master Jul 28, 2018
@JeffBezanson JeffBezanson deleted the jn/win-tty-utf8 branch July 28, 2018 17:30
@KristofferC KristofferC mentioned this pull request Jul 31, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bugfix This change fixes an existing bug io Involving the I/O subsystem: libuv, read, write, etc. system:windows Affects only Windows

Projects

None yet

Milestone

0.7

Development

Successfully merging this pull request may close these issues.

4 participants

@vtjnash @JeffBezanson @yeonsookimdev