Defined size(::Broadcasted) #31369
Merged
Defined size(::Broadcasted) #31369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbauman
approved these changes
Mar 16, 2019
Contributor
|
Is this really OK for broadcasts of offset arrays? As far as I understood the docs, defining |
Member
|
That’s no longer the case (but was indeed one of the reasons I didn’t do this initially). #24899 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found myself wanting this definition and it seems odd to not have it when we have
axesandlength. While going to define a test, I noticed that the tests already used this function with the spellinglength.(axes(bc)), which further reinforced that this is a useful thing to have (plus providing an automatic test case).