Fix realpath() assumptions in REPL test suite
#33819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On non-case-sensitive platforms, it is possible for `cd` and `pwd()` to return values that are different from what `realpath()` of the same would give back. Therefore, we must adjust our tests to be more robust against this variation. This should hopefully fix some of the testing hangs on Windows
delete no-op code
Member
|
Squash plz. |
KristofferC
pushed a commit
that referenced
this pull request
Nov 14, 2019
Fix `realpath()` assumptions in REPL test suite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On non-case-sensitive platforms, it is possible for
cdandpwd()toreturn values that are different from what
realpath()of the samewould give back. Therefore, we must adjust our tests to be more robust
against this variation.
This should hopefully fix some of the testing hangs on Windows