Add specialized unique(::AbstractRange) method #36836
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanKarpinski
added
the
minor change
Member
|
I think this is ok to change in a minor release. This does seem like a good optimization to have. |
Contributor
Author
|
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is no specialized
uniqueimplementation for ranges, souniquefalls back to the default implementation for iterators, which seems wasteful.This PR implements
unique(::AbstractRange)and simplifiesallunique(::AbstractRange).unique(::AbstractRange)now returns a range instead of aVector. Is it okay thatuniquedoes not return a mutable collection, or should I change it to return aVectorlike before?