Skip to content

Adjust calling convention of LAPACK functions #38836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 13, 2020
Merged

Adjust calling convention of LAPACK functions #38836

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42104ee
Adjust calling convetion of dgebal and co
vchuravy Dec 11, 2020
929a7f8
Adjust calling convention of BLAS & LAPACK
vchuravy Dec 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
94 changes: 54 additions & 40 deletions stdlib/LinearAlgebra/src/blas.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -704,10 +704,10 @@ for (fname, elty) in ((:dgemv_,:Float64),
ccall((@blasfunc($fname), libblas), Cvoid,
(Ref{UInt8}, Ref{BlasInt}, Ref{BlasInt}, Ref{$elty},
Ptr{$elty}, Ref{BlasInt}, Ptr{$elty}, Ref{BlasInt},
Ref{$elty}, Ptr{$elty}, Ref{BlasInt}),
Ref{$elty}, Ptr{$elty}, Ref{BlasInt}, Clong),
trans, size(A,1), size(A,2), alpha,
A, max(1,stride(A,2)), X, stride(X,1),
beta, Y, stride(Y,1))
beta, Y, stride(Y,1), 1)
Y
end
function gemv(trans::AbstractChar, alpha::($elty), A::AbstractMatrix{$elty}, X::AbstractVector{$elty})
Expand Down Expand Up @@ -785,10 +785,10 @@ for (fname, elty) in ((:dgbmv_,:Float64),
(Ref{UInt8}, Ref{BlasInt}, Ref{BlasInt}, Ref{BlasInt},
Ref{BlasInt}, Ref{$elty}, Ptr{$elty}, Ref{BlasInt},
Ptr{$elty}, Ref{BlasInt}, Ref{$elty}, Ptr{$elty},
Ref{BlasInt}),
Ref{BlasInt}, Clong),
trans, m, size(A,2), kl,
ku, alpha, A, max(1,stride(A,2)),
x, stride(x,1), beta, y, stride(y,1))
x, stride(x,1), beta, y, stride(y,1), 1)
y
end
function gbmv(trans::AbstractChar, m::Integer, kl::Integer, ku::Integer, alpha::($elty), A::AbstractMatrix{$elty}, x::AbstractVector{$elty})
Expand Down Expand Up @@ -844,10 +844,10 @@ for (fname, elty, lib) in ((:dsymv_,:Float64,libblas),
ccall((@blasfunc($fname), $lib), Cvoid,
(Ref{UInt8}, Ref{BlasInt}, Ref{$elty}, Ptr{$elty},
Ref{BlasInt}, Ptr{$elty}, Ref{BlasInt}, Ref{$elty},
Ptr{$elty}, Ref{BlasInt}),
Ptr{$elty}, Ref{BlasInt}, Clong),
uplo, n, alpha, A,
max(1,stride(A,2)), x, stride(x,1), beta,
y, stride(y,1))
y, stride(y,1), 1)
y
end
function symv(uplo::AbstractChar, alpha::($elty), A::AbstractMatrix{$elty}, x::AbstractVector{$elty})
Expand Down Expand Up @@ -908,10 +908,10 @@ for (fname, elty) in ((:zhemv_,:ComplexF64),
ccall((@blasfunc($fname), libblas), Cvoid,
(Ref{UInt8}, Ref{BlasInt}, Ref{$elty}, Ptr{$elty},
Ref{BlasInt}, Ptr{$elty}, Ref{BlasInt}, Ref{$elty},
Ptr{$elty}, Ref{BlasInt}),
Ptr{$elty}, Ref{BlasInt}, Clong),
uplo, n, α, A,
lda, x, incx, β,
y, incy)
y, incy, 1)
y
end
function hemv(uplo::AbstractChar, α::($elty), A::AbstractMatrix{$elty}, x::AbstractVector{$elty})
Expand Down Expand Up @@ -971,7 +971,8 @@ for (fname, elty) in ((:zhpmv_, :ComplexF64),
Ref{BlasInt}, # incx,
Ref{$elty}, # β,
Ptr{$elty}, # y, output
Ref{BlasInt}), # incy
Ref{BlasInt}, # incy
Clong), # length of uplo
uplo,
n,
α,
Expand All @@ -980,7 +981,8 @@ for (fname, elty) in ((:zhpmv_, :ComplexF64),
incx,
β,
y,
incy)
incy,
1)
return y
end
end
Expand Down Expand Up @@ -1041,10 +1043,10 @@ for (fname, elty) in ((:dsbmv_,:Float64),
ccall((@blasfunc($fname), libblas), Cvoid,
(Ref{UInt8}, Ref{BlasInt}, Ref{BlasInt}, Ref{$elty},
Ptr{$elty}, Ref{BlasInt}, Ptr{$elty}, Ref{BlasInt},
Ref{$elty}, Ptr{$elty}, Ref{BlasInt}),
Ref{$elty}, Ptr{$elty}, Ref{BlasInt}, Clong),
uplo, size(A,2), k, alpha,
A, max(1,stride(A,2)), x, stride(x,1),
beta, y, stride(y,1))
beta, y, stride(y,1), 1)
y
end
function sbmv(uplo::AbstractChar, k::Integer, alpha::($elty), A::AbstractMatrix{$elty}, x::AbstractVector{$elty})
Expand Down Expand Up @@ -1119,7 +1121,8 @@ for (fname, elty) in ((:dspmv_, :Float64),
Ref{BlasInt}, # incx,
Ref{$elty}, # β,
Ptr{$elty}, # y, out
Ref{BlasInt}), # incy
Ref{BlasInt}, # incy
Clong), # length of uplo
uplo,
n,
α,
Expand All @@ -1128,7 +1131,8 @@ for (fname, elty) in ((:dspmv_, :Float64),
incx,
β,
y,
incy)
incy,
1)
return y
end
end
Expand Down Expand Up @@ -1189,10 +1193,10 @@ for (fname, elty) in ((:zhbmv_,:ComplexF64),
ccall((@blasfunc($fname), libblas), Cvoid,
(Ref{UInt8}, Ref{BlasInt}, Ref{BlasInt}, Ref{$elty},
Ptr{$elty}, Ref{BlasInt}, Ptr{$elty}, Ref{BlasInt},
Ref{$elty}, Ptr{$elty}, Ref{BlasInt}),
Ref{$elty}, Ptr{$elty}, Ref{BlasInt}, Clong),
uplo, size(A,2), k, alpha,
A, max(1,stride(A,2)), x, stride(x,1),
beta, y, stride(y,1))
beta, y, stride(y,1), 1)
y
end
function hbmv(uplo::AbstractChar, k::Integer, alpha::($elty), A::AbstractMatrix{$elty}, x::AbstractVector{$elty})
Expand Down Expand Up @@ -1248,9 +1252,10 @@ for (fname, elty) in ((:dtrmv_,:Float64),
chkstride1(A)
ccall((@blasfunc($fname), libblas), Cvoid,
(Ref{UInt8}, Ref{UInt8}, Ref{UInt8}, Ref{BlasInt},
Ptr{$elty}, Ref{BlasInt}, Ptr{$elty}, Ref{BlasInt}),
Ptr{$elty}, Ref{BlasInt}, Ptr{$elty}, Ref{BlasInt},
Clong, Clong, Clong),
uplo, trans, diag, n,
A, max(1,stride(A,2)), x, max(1,stride(x, 1)))
A, max(1,stride(A,2)), x, max(1,stride(x, 1)), 1, 1, 1)
x
end
function trmv(uplo::AbstractChar, trans::AbstractChar, diag::AbstractChar, A::AbstractMatrix{$elty}, x::AbstractVector{$elty})
Expand Down Expand Up @@ -1302,9 +1307,10 @@ for (fname, elty) in ((:dtrsv_,:Float64),
chkstride1(A)
ccall((@blasfunc($fname), libblas), Cvoid,
(Ref{UInt8}, Ref{UInt8}, Ref{UInt8}, Ref{BlasInt},
Ptr{$elty}, Ref{BlasInt}, Ptr{$elty}, Ref{BlasInt}),
Ptr{$elty}, Ref{BlasInt}, Ptr{$elty}, Ref{BlasInt},
Clong, Clong, Clong),
uplo, trans, diag, n,
A, max(1,stride(A,2)), x, stride(x, 1))
A, max(1,stride(A,2)), x, stride(x, 1), 1, 1, 1)
x
end
function trsv(uplo::AbstractChar, trans::AbstractChar, diag::AbstractChar, A::AbstractMatrix{$elty}, x::AbstractVector{$elty})
Expand Down Expand Up @@ -1398,9 +1404,9 @@ for (fname, elty, relty) in ((:zher_,:ComplexF64, :Float64),
end
ccall((@blasfunc($fname), libblas), Cvoid,
(Ref{UInt8}, Ref{BlasInt}, Ref{$relty}, Ptr{$elty},
Ref{BlasInt}, Ptr{$elty}, Ref{BlasInt}),
Ref{BlasInt}, Ptr{$elty}, Ref{BlasInt}, Clong),
uplo, n, α, x,
stride(x, 1), A, max(1,stride(A,2)))
stride(x, 1), A, max(1,stride(A,2)), 1)
A
end
end
Expand Down Expand Up @@ -1453,11 +1459,11 @@ for (gemm, elty) in
(Ref{UInt8}, Ref{UInt8}, Ref{BlasInt}, Ref{BlasInt},
Ref{BlasInt}, Ref{$elty}, Ptr{$elty}, Ref{BlasInt},
Ptr{$elty}, Ref{BlasInt}, Ref{$elty}, Ptr{$elty},
Ref{BlasInt}),
Ref{BlasInt}, Clong, Clong),
transA, transB, m, n,
ka, alpha, A, max(1,stride(A,2)),
B, max(1,stride(B,2)), beta, C,
max(1,stride(C,2)))
max(1,stride(C,2)), 1, 1)
C
end
function gemm(transA::AbstractChar, transB::AbstractChar, alpha::($elty), A::AbstractMatrix{$elty}, B::AbstractMatrix{$elty})
Expand Down Expand Up @@ -1515,10 +1521,12 @@ for (mfname, elty) in ((:dsymm_,:Float64),
ccall((@blasfunc($mfname), libblas), Cvoid,
(Ref{UInt8}, Ref{UInt8}, Ref{BlasInt}, Ref{BlasInt},
Ref{$elty}, Ptr{$elty}, Ref{BlasInt}, Ptr{$elty},
Ref{BlasInt}, Ref{$elty}, Ptr{$elty}, Ref{BlasInt}),
Ref{BlasInt}, Ref{$elty}, Ptr{$elty}, Ref{BlasInt},
Clong, Clong),
side, uplo, m, n,
alpha, A, max(1,stride(A,2)), B,
max(1,stride(B,2)), beta, C, max(1,stride(C,2)))
max(1,stride(B,2)), beta, C, max(1,stride(C,2)),
1, 1)
C
end
function symm(side::AbstractChar, uplo::AbstractChar, alpha::($elty), A::AbstractMatrix{$elty}, B::AbstractMatrix{$elty})
Expand Down Expand Up @@ -1586,10 +1594,12 @@ for (mfname, elty) in ((:zhemm_,:ComplexF64),
ccall((@blasfunc($mfname), libblas), Cvoid,
(Ref{UInt8}, Ref{UInt8}, Ref{BlasInt}, Ref{BlasInt},
Ref{$elty}, Ptr{$elty}, Ref{BlasInt}, Ptr{$elty},
Ref{BlasInt}, Ref{$elty}, Ptr{$elty}, Ref{BlasInt}),
Ref{BlasInt}, Ref{$elty}, Ptr{$elty}, Ref{BlasInt},
Clong, Clong),
side, uplo, m, n,
alpha, A, max(1,stride(A,2)), B,
max(1,stride(B,2)), beta, C, max(1,stride(C,2)))
max(1,stride(B,2)), beta, C, max(1,stride(C,2)),
1, 1)
C
end
function hemm(side::AbstractChar, uplo::AbstractChar, alpha::($elty), A::AbstractMatrix{$elty}, B::AbstractMatrix{$elty})
Expand Down Expand Up @@ -1673,10 +1683,10 @@ for (fname, elty) in ((:dsyrk_,:Float64),
ccall((@blasfunc($fname), libblas), Cvoid,
(Ref{UInt8}, Ref{UInt8}, Ref{BlasInt}, Ref{BlasInt},
Ref{$elty}, Ptr{$elty}, Ref{BlasInt}, Ref{$elty},
Ptr{$elty}, Ref{BlasInt}),
Ptr{$elty}, Ref{BlasInt}, Clong, Clong),
uplo, trans, n, k,
alpha, A, max(1,stride(A,2)), beta,
C, max(1,stride(C,2)))
C, max(1,stride(C,2)), 1, 1)
C
end
end
Expand Down Expand Up @@ -1731,10 +1741,10 @@ for (fname, elty, relty) in ((:zherk_, :ComplexF64, :Float64),
ccall((@blasfunc($fname), libblas), Cvoid,
(Ref{UInt8}, Ref{UInt8}, Ref{BlasInt}, Ref{BlasInt},
Ref{$relty}, Ptr{$elty}, Ref{BlasInt}, Ref{$relty},
Ptr{$elty}, Ref{BlasInt}),
Ptr{$elty}, Ref{BlasInt}, Clong, Clong),
uplo, trans, n, k,
α, A, max(1,stride(A,2)), β,
C, max(1,stride(C,2)))
C, max(1,stride(C,2)), 1, 1)
C
end
function herk(uplo::AbstractChar, trans::AbstractChar, α::$relty, A::AbstractVecOrMat{$elty})
Expand Down Expand Up @@ -1774,10 +1784,10 @@ for (fname, elty) in ((:dsyr2k_,:Float64),
ccall((@blasfunc($fname), libblas), Cvoid,
(Ref{UInt8}, Ref{UInt8}, Ref{BlasInt}, Ref{BlasInt},
Ref{$elty}, Ptr{$elty}, Ref{BlasInt}, Ptr{$elty}, Ref{BlasInt}, Ref{$elty},
Ptr{$elty}, Ref{BlasInt}),
Ptr{$elty}, Ref{BlasInt}, Clong, Clong),
uplo, trans, n, k,
alpha, A, max(1,stride(A,2)), B, max(1,stride(B,2)), beta,
C, max(1,stride(C,2)))
C, max(1,stride(C,2)), 1, 1)
C
end
end
Expand Down Expand Up @@ -1841,10 +1851,10 @@ for (fname, elty1, elty2) in ((:zher2k_,:ComplexF64,:Float64), (:cher2k_,:Comple
ccall((@blasfunc($fname), libblas), Cvoid,
(Ref{UInt8}, Ref{UInt8}, Ref{BlasInt}, Ref{BlasInt},
Ref{$elty1}, Ptr{$elty1}, Ref{BlasInt}, Ptr{$elty1}, Ref{BlasInt},
Ref{$elty2}, Ptr{$elty1}, Ref{BlasInt}),
Ref{$elty2}, Ptr{$elty1}, Ref{BlasInt}, Clong, Clong),
uplo, trans, n, k,
alpha, A, max(1,stride(A,2)), B, max(1,stride(B,2)),
beta, C, max(1,stride(C,2)))
beta, C, max(1,stride(C,2)), 1, 1)
C
end
function her2k(uplo::AbstractChar, trans::AbstractChar, alpha::($elty1), A::AbstractVecOrMat{$elty1}, B::AbstractVecOrMat{$elty1})
Expand Down Expand Up @@ -1954,9 +1964,11 @@ for (mmname, smname, elty) in
chkstride1(B)
ccall((@blasfunc($mmname), libblas), Cvoid,
(Ref{UInt8}, Ref{UInt8}, Ref{UInt8}, Ref{UInt8}, Ref{BlasInt}, Ref{BlasInt},
Ref{$elty}, Ptr{$elty}, Ref{BlasInt}, Ptr{$elty}, Ref{BlasInt}),
Ref{$elty}, Ptr{$elty}, Ref{BlasInt}, Ptr{$elty}, Ref{BlasInt},
Clong, Clong, Clong, Clong),
side, uplo, transa, diag, m, n,
alpha, A, max(1,stride(A,2)), B, max(1,stride(B,2)))
alpha, A, max(1,stride(A,2)), B, max(1,stride(B,2)),
1, 1, 1, 1)
B
end
function trmm(side::AbstractChar, uplo::AbstractChar, transa::AbstractChar, diag::AbstractChar,
Expand All @@ -1983,10 +1995,12 @@ for (mmname, smname, elty) in
ccall((@blasfunc($smname), libblas), Cvoid,
(Ref{UInt8}, Ref{UInt8}, Ref{UInt8}, Ref{UInt8},
Ref{BlasInt}, Ref{BlasInt}, Ref{$elty}, Ptr{$elty},
Ref{BlasInt}, Ptr{$elty}, Ref{BlasInt}),
Ref{BlasInt}, Ptr{$elty}, Ref{BlasInt},
Clong, Clong, Clong, Clong),
side, uplo, transa, diag,
m, n, alpha, A,
max(1,stride(A,2)), B, max(1,stride(B,2)))
max(1,stride(A,2)), B, max(1,stride(B,2)),
1, 1, 1, 1)
B
end
function trsm(side::AbstractChar, uplo::AbstractChar, transa::AbstractChar, diag::AbstractChar, alpha::$elty, A::AbstractMatrix{$elty}, B::AbstractMatrix{$elty})
Expand Down
Loading