Skip to content

workaround for #40048, stack overflow in type intersection #41091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

workaround for #40048, stack overflow in type intersection #41091

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/gf.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1597,6 +1597,8 @@ static int jl_type_intersection2(jl_value_t *t1, jl_value_t *t2, jl_value_t **is
*isect = jl_type_intersection_env_s(t1, t2, NULL, &is_subty);
if (*isect == jl_bottom_type)
return 0;
// TODO: This extra call to intersection sometimes hits bad cases, e.g. issue #40048.
/*
if (is_subty)
return 1;
// TODO: sometimes type intersection returns types with free variables
Expand All @@ -1613,6 +1615,7 @@ static int jl_type_intersection2(jl_value_t *t1, jl_value_t *t2, jl_value_t **is
if (jl_types_egal(*isect2, *isect)) {
*isect2 = NULL;
}
*/
return 1;
}

Expand Down