switch OpaqueClosure from isva field to separate argument tuple type
#44008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
force-pushed
the
jb/novaoverride2
branch
from
1ee5507 to
4380028
Compare
Keno
approved these changes
Feb 2, 2022
JeffBezanson
force-pushed
the
jb/novaoverride2
branch
2 times, most recently
from
cd09901 to
59089f0
Compare
JeffBezanson
force-pushed
the
jb/novaoverride2
branch
2 times, most recently
from
5bccf4b to
de69e0d
Compare
Instead allow specifying an argument tuple type separately.
JeffBezanson
force-pushed
the
jb/novaoverride2
branch
from
de69e0d to
709d73d
Compare
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
Feb 17, 2022
Instead allow specifying an argument tuple type separately.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
Instead allow specifying an argument tuple type separately.
vtjnash
reviewed
Feb 22, 2022
Member
vtjnash
left a comment
vtjnash
left a comment
There was a problem hiding this comment.
Good cleanup. I think there is a missing JL_TYPECHK / jl_is_datatype though (at the marked place)?
| // TODO: remove | ||
| jl_value_t *jl_fptr_va_opaque_closure(jl_opaque_closure_t *oc, jl_value_t **args, size_t nargs) | ||
| // determine whether `argt` is a valid argument type tuple for the given opaque closure method | ||
| JL_DLLEXPORT int jl_is_valid_oc_argtype(jl_tupletype_t *argt, jl_method_t *source) |
Member
There was a problem hiding this comment.
This seems to assume that argt is a datatype, without checking?
Member
Author
There was a problem hiding this comment.
jl_new_opaque_closure checks jl_is_tuple_type, and the other caller in codegen does as well.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
Instead allow specifying an argument tuple type separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #43320, but I will put this up now for review.
TODO: Add signature type compatibility check in codegen.