Skip to content

Conversation

@vilterp
Copy link
Contributor

@vilterp vilterp commented Feb 8, 2022

Since we think we're now getting all the allocs:

Maybe we should still log a warning about missing types?

cc @NHDaly

Copy link
Member

@NHDaly NHDaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rad. Thanks Pete. I'll wait for green CI then merge!

@vilterp
Copy link
Contributor Author

vilterp commented Feb 9, 2022

error:

Error in testset Test:
Test Failed at C:\buildbot\worker-tabularasa\tester_win64\build\share\julia\stdlib\v1.8\Test\test\runtests.jl:795
  Expression: orig == Random.default_rng()
   Evaluated: Xoshiro(0x9323c7422b2ab408, 0x571e9459461288f3, 0xfdbbd5235ca4df18, 0xbfccf06b9ac9bc6b) == TaskLocalRNG()
Error in testset Test:
Test Failed at C:\buildbot\worker-tabularasa\tester_win64\build\share\julia\stdlib\v1.8\Test\test\runtests.jl:796
  Expression: rand(orig) == rand()
   Evaluated: 0.4141655849278584 == 0.4104343156769663

Not sure what this has to do with us 🤔

@NHDaly
Copy link
Member

NHDaly commented Feb 9, 2022

Yes agreed, this one seems unrelated (maybe flaky?).
If everything is green, this should be ready to merge. (waiting on freebsd64)

@NHDaly
Copy link
Member

NHDaly commented Feb 9, 2022

(Freebsd tests never ran; there must be something wrong with the bulid bot. Going to merge now; this is mostly a docs cleanup.)

@NHDaly NHDaly merged commit 76fa182 into JuliaLang:master Feb 9, 2022
@vchuravy vchuravy deleted the pv-move-alloc-warnings branch February 9, 2022 22:33
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request Feb 17, 2022
…mplementation (JuliaLang#44077)

* docs: update warning in the manual; add to reference

* remove missed allocs warning from `fetch`

since we think we've gotten all the allocs

* remove tests of warning message, since it's no longer there
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
…mplementation (JuliaLang#44077)

* docs: update warning in the manual; add to reference

* remove missed allocs warning from `fetch`

since we think we've gotten all the allocs

* remove tests of warning message, since it's no longer there
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
…mplementation (JuliaLang#44077)

* docs: update warning in the manual; add to reference

* remove missed allocs warning from `fetch`

since we think we've gotten all the allocs

* remove tests of warning message, since it's no longer there
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants