[test] Drop running_under_rr() check
#44693
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
approved these changes
Mar 22, 2022
|
Looks like it's not working. :P |
|
Probably because we tell rr to emulate 8 cores. |
|
There's 16 cores here. Are we still configuring buildkite to override the default settings for nthreads (which we are testing here)? |
Since we're now explicitly checking that we have the ability to set affinity, we shouldn't need this check for `rr`, we can more directly avoid the problematic tests due to `rr` setting us to single-core affinity already.
staticfloat
force-pushed
the
sf/simplify_threading_check
branch
from
c5eae46 to
c5758a6
Compare
|
So it looks like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're now explicitly checking that we have the ability to set
affinity, we shouldn't need this check for
rr, we can more directlyavoid the problematic tests due to
rrsetting us to single-coreaffinity already.