Skip to content

Conversation

@LilithHafner
Copy link
Member

@LilithHafner LilithHafner commented Aug 27, 2022

This is my first time touching the compiler, so I'd appreciate a careful review!

I'm assuming that defs and uses are disjoint and increasing and that block_for_inst is a nondecreasing function.

This is motivated by my belief that almost all uses of sort can be replaced with more performant alternatives.

@LilithHafner LilithHafner added performance Must go faster compiler:optimizer Optimization passes (mostly in base/compiler/ssair/) labels Aug 27, 2022
@LilithHafner LilithHafner changed the title Reduce allocations in optimizer hotpath? Optimize compute_live_ins in optimizer hotpath Aug 27, 2022
@aviatesk
Copy link
Member

@nanosoldier runbenchmarks("inference", vs=":master")

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - no performance regressions were detected. A full report can be found here.

@JeffBezanson
Copy link
Member

Any noticeable compile time improvements from this?

@vtjnash vtjnash merged commit 71131c9 into master Sep 1, 2022
@vtjnash vtjnash deleted the optimizer-allocs branch September 1, 2022 16:37
@LilithHafner
Copy link
Member Author

None that I know of. Perhaps this was not really a bottleneck.

@thofma
Copy link
Contributor

thofma commented Sep 23, 2022

A bisect shows that this broke Hecke. Here is an example for the backtrace: https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_date/2022-09/22/Hecke.primary.log
(Do not be deceived by the "successful" at the end.)

Should I open a separate issue?

@LilithHafner LilithHafner mentioned this pull request Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compiler:optimizer Optimization passes (mostly in base/compiler/ssair/) performance Must go faster

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants