Skip to content

Revert "add more methods and tests for reductions over empty arrays" #52003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2023
Merged

Revert "add more methods and tests for reductions over empty arrays" #52003

merged 1 commit into from
Nov 2, 2023

Conversation

@vtjnash
Copy link
Member

@vtjnash vtjnash commented Nov 2, 2023

Reverts #29919

CI was older than I realized on this, so this needed some updates to tests and docstrings

@vtjnash vtjnash merged commit 2a84214 into master Nov 2, 2023
@vtjnash vtjnash deleted the revert-29919-sb/reduce-empty branch November 2, 2023 20:10
vtjnash added a commit that referenced this pull request Nov 2, 2023
@vtjnash
Revert "Revert "add more methods and tests for reductions over empty …
b87fdeb 
…arrays" (#52003)"

This reverts commit 2a84214.
vtjnash added a commit that referenced this pull request Apr 16, 2024
@vtjnash
Reland "add more methods and tests for reductions over empty arrays"
6ca85cd 
Refs #29919
Refs #52003

This reverts commit 2a84214.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vtjnash