Update readstring(x) to read(x, String)

Author: omus

test/import.jl

@@ -1,4 +1,4 @@
-import Compat: readstring
+import Compat: read
 
 # Patches should allow using imported bindings in the body of the patch
 @test_throws UndefVarError Minute
@@ -20,15 +20,15 @@ end
 @test_throws UndefVarError AbstractCmd
 @test isdefined(Base, :AbstractCmd)
 
-patch = @patch readstring(cmd::Base.AbstractCmd) = "bar"
+patch = @patch read(cmd::Base.AbstractCmd, ::Type{String}) = "bar"
 apply(patch) do
-    @test (@mock readstring(`foo`)) == "bar"
+    @test (@mock read(`foo`, String)) == "bar"
 end
 
 # Patches should allow using imported bindings syntax in the signature
 import Base: AbstractCmd
 
-patch = @patch readstring(cmd::AbstractCmd) = "bar"
+patch = @patch read(cmd::AbstractCmd, ::Type{String}) = "bar"
 apply(patch) do
-    @test (@mock readstring(`foo`)) == "bar"
+    @test (@mock read(`foo`, String)) == "bar"
 end

test/real-nested.jl

@@ -1,7 +1,7 @@
-import Compat: readstring
+import Compat: read
 
 let
-    readfile(filename) = (@mock isfile(filename)) ? readstring(@mock open(filename)) : ""
+    readfile(filename) = (@mock isfile(filename)) ? read((@mock open(filename)), String) : ""
 
     # Testing with both generic and anonymous functions
     patches = Patch[

test/real-open.jl

@@ -1,4 +1,4 @@
-import Compat: readstring
+import Compat: read
 
 let
     # Ensure that open cannot find the file "foo"
@@ -9,19 +9,19 @@ let
     # will be preferred over the original `open(::AbstractString)` for `open("foo")`
     patch = @patch open(name) = IOBuffer("bar")
     apply(patch) do
-        @test readstring(@mock open("foo")) == "bar"
+        @test read((@mock open("foo")), String) == "bar"
 
         # The `open(::Any)` patch could result in unintended (or intended) consequences
-        @test readstring(@mock open(`echo helloworld`)) == "bar"
+        @test read((@mock open(`echo helloworld`)), String) == "bar"
     end
 
     # Better to be specific with your patches
     patch = @patch open(name::AbstractString) = IOBuffer("bar")
     apply(patch) do
-        @test readstring(@mock open("foo")) == "bar"
+        @test read((@mock open("foo")), String) == "bar"
 
         # The more specific `open(::AbstractString)` patches only a single method
-        io, pobj = (@mock open(`echo helloworld`))
-        @test readstring(io) == "helloworld\n"
+        io, pobj = @mock open(`echo helloworld`)
+        @test read(io, String) == "helloworld\n"
     end
 end