Fix hole::blind diameter on simple holes (#8806)

* Fix hole::blind diameter on simple holes
Fixes #8805

* Update test output

Author: pierremtb

rust/kcl-lib/std/hole.kcl

@@ -177,7 +177,7 @@ export fn flat() {
 fn drawTop(@partialHoleProfile, body, holeType) {
   prof = if holeType.feature == holeTypeSimple {
     partialHoleProfile
-      |> xLine(length = body.diameter)
+      |> xLine(length = body.diameter / 2)
   } else if holeType.feature == holeTypeCounterbore {
     lip = (holeType.diameter - body.diameter) / 2
     partialHoleProfile

rust/kcl-lib/tests/holes_cube/artifact_commands.snap

@@ -1069,7 +1069,7 @@ description: Artifact commands holes_cube.kcl
         "segment": {
           "type": "line",
           "end": {
-            "x": 4.0,
+            "x": 2.0,
             "y": 0.0,
             "z": 0.0
           },

rust/kcl-lib/tests/holes_cube/artifact_graph_flowchart.snap.md

@@ -16,38 +16,38 @@ flowchart LR
     8[Solid2d]
   end
   subgraph path27 [Path]
-    27["Path<br>[7981, 8031, 15]"]
-    28["Segment<br>[8060, 8087, 15]"]
-    29["Segment<br>[8113, 8154, 15]"]
-    30["Segment<br>[6266, 6284, 15]"]
-    31["Segment<br>[6294, 6312, 15]"]
-    32["Segment<br>[6322, 6368, 15]"]
-    33["Segment<br>[8222, 8254, 15]"]
-    34["Segment<br>[8286, 8342, 15]"]
-    35["Segment<br>[8350, 8357, 15]"]
+    27["Path<br>[7985, 8035, 15]"]
+    28["Segment<br>[8064, 8091, 15]"]
+    29["Segment<br>[8117, 8158, 15]"]
+    30["Segment<br>[6270, 6288, 15]"]
+    31["Segment<br>[6298, 6316, 15]"]
+    32["Segment<br>[6326, 6372, 15]"]
+    33["Segment<br>[8226, 8258, 15]"]
+    34["Segment<br>[8290, 8346, 15]"]
+    35["Segment<br>[8354, 8361, 15]"]
     36[Solid2d]
   end
   subgraph path48 [Path]
-    48["Path<br>[7981, 8031, 15]"]
-    49["Segment<br>[8060, 8087, 15]"]
-    50["Segment<br>[8113, 8154, 15]"]
-    51["Segment<br>[5653, 5683, 15]"]
-    52["Segment<br>[5693, 5730, 15]"]
-    53["Segment<br>[5740, 5771, 15]"]
-    54["Segment<br>[5781, 5801, 15]"]
-    55["Segment<br>[8222, 8254, 15]"]
-    56["Segment<br>[8286, 8342, 15]"]
-    57["Segment<br>[8350, 8357, 15]"]
+    48["Path<br>[7985, 8035, 15]"]
+    49["Segment<br>[8064, 8091, 15]"]
+    50["Segment<br>[8117, 8158, 15]"]
+    51["Segment<br>[5657, 5687, 15]"]
+    52["Segment<br>[5697, 5734, 15]"]
+    53["Segment<br>[5744, 5775, 15]"]
+    54["Segment<br>[5785, 5805, 15]"]
+    55["Segment<br>[8226, 8258, 15]"]
+    56["Segment<br>[8290, 8346, 15]"]
+    57["Segment<br>[8354, 8361, 15]"]
     58[Solid2d]
   end
   subgraph path72 [Path]
-    72["Path<br>[7981, 8031, 15]"]
-    73["Segment<br>[8060, 8087, 15]"]
-    74["Segment<br>[8113, 8154, 15]"]
-    75["Segment<br>[5487, 5516, 15]"]
-    76["Segment<br>[8222, 8254, 15]"]
-    77["Segment<br>[8286, 8342, 15]"]
-    78["Segment<br>[8350, 8357, 15]"]
+    72["Path<br>[7985, 8035, 15]"]
+    73["Segment<br>[8064, 8091, 15]"]
+    74["Segment<br>[8117, 8158, 15]"]
+    75["Segment<br>[5487, 5520, 15]"]
+    76["Segment<br>[8226, 8258, 15]"]
+    77["Segment<br>[8290, 8346, 15]"]
+    78["Segment<br>[8354, 8361, 15]"]
     79[Solid2d]
   end
   1["Plane<br>[64, 81, 0]"]
@@ -76,9 +76,9 @@ flowchart LR
   23["SweepEdge Adjacent"]
   24["EdgeCut Fillet<br>[421, 890, 0]"]
     %% [ProgramBodyItem { index: 1 }, VariableDeclarationDeclaration, VariableDeclarationInit, PipeBodyItem { index: 9 }]
-  25["PlaneOfFace<br>[8946, 9049, 15]"]
-  26["Plane<br>[8946, 9049, 15]"]
-  37["Sweep RevolveAboutEdge<br>[8637, 8657, 15]"]
+  25["PlaneOfFace<br>[8950, 9053, 15]"]
+  26["Plane<br>[8950, 9053, 15]"]
+  37["Sweep RevolveAboutEdge<br>[8641, 8661, 15]"]
   38[Wall]
     %% face_code_ref=Missing NodePath
   39[Wall]
@@ -90,10 +90,10 @@ flowchart LR
   42["SweepEdge Adjacent"]
   43["SweepEdge Adjacent"]
   44["SweepEdge Adjacent"]
-  45["CompositeSolid Subtract<br>[12000, 12034, 15]"]
-  46["PlaneOfFace<br>[8946, 9049, 15]"]
-  47["Plane<br>[8946, 9049, 15]"]
-  59["Sweep RevolveAboutEdge<br>[8637, 8657, 15]"]
+  45["CompositeSolid Subtract<br>[12004, 12038, 15]"]
+  46["PlaneOfFace<br>[8950, 9053, 15]"]
+  47["Plane<br>[8950, 9053, 15]"]
+  59["Sweep RevolveAboutEdge<br>[8641, 8661, 15]"]
   60[Wall]
     %% face_code_ref=Missing NodePath
   61[Wall]
@@ -108,10 +108,10 @@ flowchart LR
   66["SweepEdge Adjacent"]
   67["SweepEdge Adjacent"]
   68["SweepEdge Adjacent"]
-  69["CompositeSolid Subtract<br>[12000, 12034, 15]"]
-  70["PlaneOfFace<br>[8946, 9049, 15]"]
-  71["Plane<br>[8946, 9049, 15]"]
-  80["Sweep RevolveAboutEdge<br>[8637, 8657, 15]"]
+  69["CompositeSolid Subtract<br>[12004, 12038, 15]"]
+  70["PlaneOfFace<br>[8950, 9053, 15]"]
+  71["Plane<br>[8950, 9053, 15]"]
+  80["Sweep RevolveAboutEdge<br>[8641, 8661, 15]"]
   81[Wall]
     %% face_code_ref=Missing NodePath
   82[Wall]
@@ -120,10 +120,10 @@ flowchart LR
     %% face_code_ref=Missing NodePath
   84["SweepEdge Adjacent"]
   85["SweepEdge Adjacent"]
-  86["CompositeSolid Subtract<br>[12000, 12034, 15]"]
-  87["StartSketchOnPlane<br>[8946, 9049, 15]"]
-  88["StartSketchOnPlane<br>[8946, 9049, 15]"]
-  89["StartSketchOnPlane<br>[8946, 9049, 15]"]
+  86["CompositeSolid Subtract<br>[12004, 12038, 15]"]
+  87["StartSketchOnPlane<br>[8950, 9053, 15]"]
+  88["StartSketchOnPlane<br>[8950, 9053, 15]"]
+  89["StartSketchOnPlane<br>[8950, 9053, 15]"]
   1 --- 2
   2 --- 3
   2 --- 4