Skip to content

Commit edcc664

Browse files
committed
Run unit tests without needing a Wasm binary
1 parent c1325e0 commit edcc664

File tree

2 files changed

+3
-19
lines changed

2 files changed

+3
-19
lines changed

.github/workflows/unit-tests.yml

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@ jobs:
2121

2222
npm-test-unit:
2323
runs-on: namespace-profile-ubuntu-2-cores
24-
# TODO: Remove unit test dependency on Wasm binary
25-
needs: npm-build-wasm
2624
steps:
2725
- uses: actions/checkout@v5
2826

@@ -39,19 +37,6 @@ jobs:
3937
- name: Download all artifacts
4038
uses: actions/download-artifact@v4
4139

42-
- name: Copy prepared wasm
43-
run: |
44-
ls -R prepared-wasm
45-
cp prepared-wasm/kcl_wasm_lib_bg.wasm public
46-
mkdir rust/kcl-wasm-lib/pkg
47-
cp prepared-wasm/kcl_wasm_lib* rust/kcl-wasm-lib/pkg
48-
49-
- name: Copy prepared ts-rs bindings
50-
run: |
51-
ls -R prepared-ts-rs-bindings
52-
mkdir rust/kcl-lib/bindings
53-
cp -r prepared-ts-rs-bindings/* rust/kcl-lib/bindings/
54-
5540
- name: npm run test:unit
5641
if: ${{ github.event_name != 'release' && github.event_name != 'schedule' }}
5742
run: |-

Makefile

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -87,11 +87,11 @@ endif
8787
check: format lint
8888

8989
.PHONY: format
90-
format: install public/kcl_wasm_lib_bg.wasm ## Format the code
90+
format: install ## Format the code
9191
npm run fmt
9292

9393
.PHONY: lint
94-
lint: install public/kcl_wasm_lib_bg.wasm ## Lint the code
94+
lint: install ## Lint the code
9595
npm run tsc
9696
npm run lint
9797

@@ -130,8 +130,7 @@ endif
130130
test: test-unit test-integration test-e2e-web
131131

132132
.PHONY: test-unit
133-
test-unit: install public/kcl_wasm_lib_bg.wasm ## Run the unit tests
134-
# TODO: Remove unit test dependency on Wasm binary
133+
test-unit: install ## Run the unit tests
135134
npm run test:unit
136135

137136
.PHONY: test-integration

0 commit comments

Comments
 (0)