golangci-lint: fmt code

Author: Eikykun

.golangci.yaml

@@ -0,0 +1,12 @@
+run:
+  skip-files:
+  - ".*_test.go"
+  - pkg/utils/http/reverse_proxy.go
+  - pkg/proxy/apiserver/options.go
+  skip-dirs:
+  - vendor/
+
+linters:
+  disable:
+  - errcheck
+  - unused

e2e/customoperator/app/controller/util.go

@@ -69,14 +69,14 @@ func add(c client.Client, namespace, kind string) error {
 		if cm.Data == nil {
 			cm.Data = map[string]string{}
 		}
-		val, _ := cm.Data[key]
+		val := cm.Data[key]
 		sto := &store{}
 		if val == "" {
 			sto.Kinds = map[string]string{}
 		} else {
 			json.Unmarshal([]byte(val), sto)
 		}
-		names, _ := sto.Kinds[kind]
+		names := sto.Kinds[kind]
 		nameSet := list(names)
 		if nameSet.Has(namespace) {
 			return nil

e2e/customoperator/app/main.go

@@ -19,7 +19,6 @@ package main
 import (
 	"flag"
 	"fmt"
-	"math/rand"
 	_ "net/http/pprof"
 	"os"
 	"time"
@@ -60,8 +59,6 @@ func main() {
 	pflag.Parse()
 	ctrl.SetLogger(klogr.New())
 
-	rand.Seed(time.Now().UnixNano())
-
 	cfg := ctrl.GetConfigOrDie()
 	cfg.UserAgent = "testapp"
 

pkg/cmd/manager/main.go

@@ -18,11 +18,9 @@ package main
 
 import (
 	"flag"
-	"math/rand"
 	"net/http"
 	_ "net/http/pprof"
 	"os"
-	"time"
 
 	"github.com/spf13/pflag"
 	"k8s.io/apimachinery/pkg/runtime"
@@ -82,8 +80,6 @@ func main() {
 	pflag.Parse()
 	ctrl.SetLogger(klogr.New())
 
-	rand.Seed(time.Now().UnixNano())
-
 	go func() {
 		if err := http.ListenAndServe(pprofAddr, nil); err != nil {
 			setupLog.Error(err, "unable to start pprof")

pkg/cmd/proxy/main.go

@@ -20,11 +20,9 @@ import (
 	"context"
 	"flag"
 	"fmt"
-	"math/rand"
 	"net"
 	"net/http"
 	"os"
-	"time"
 
 	"github.com/prometheus/client_golang/prometheus/promhttp"
 	"github.com/spf13/pflag"
@@ -53,7 +51,6 @@ var (
 )
 
 func main() {
-	rand.Seed(time.Now().UnixNano())
 	pflag.CommandLine.AddGoFlagSet(flag.CommandLine)
 	pflag.Parse()
 
@@ -106,15 +103,11 @@ func main() {
 
 	serveHTTP(ctx, readyHandler)
 	if stoppedWebhook != nil {
-		select {
-		case <-stoppedWebhook:
-			klog.Infof("Webhook proxy stopped")
-		}
-	}
-	select {
-	case <-stoppedApiserver:
-		klog.Infof("Apiserver proxy stopped")
+		<-stoppedWebhook
+		klog.Infof("Webhook proxy stopped")
 	}
+	<-stoppedApiserver
+	klog.Infof("Apiserver proxy stopped")
 }
 
 func serveHTTP(ctx context.Context, readyHandler *healthz.Handler) {

pkg/grpcregistry/grpc_registry.go

@@ -98,7 +98,12 @@ func (r *grpcRegistry) Start(ctx context.Context) error {
 		return fmt.Errorf("error listening grpc server address %s: %v", addr, err)
 	}
 	klog.Infof("Start listening gRPC server with leaderElection=%v on %s", r.needLeaderElection, addr)
-	go grpcServer.Serve(lis)
+	go func() {
+		if err = grpcServer.Serve(lis); err != nil {
+			klog.Errorf("serve gRPC error %v", err)
+		}
+	}()
+
 	<-ctx.Done()
 	return nil
 }

pkg/manager/controllers/patchrunnable/labelpatch_runnable.go

@@ -282,7 +282,6 @@ func (p *PatchRunnable) setInvalid(gvk schema.GroupVersionKind) {
 	p.invalidL.Lock()
 	defer p.invalidL.Unlock()
 	p.invalid.Insert(groupVersionKindKey(gvk))
-	return
 }
 
 func groupVersionKindKey(gvk schema.GroupVersionKind) string {

pkg/manager/controllers/patchrunnable/patchrunnable_test.go

@@ -19,6 +19,7 @@ package patchrunnable
 import (
 	"context"
 	"fmt"
+	"math/rand"
 	"net/url"
 	"path/filepath"
 	"testing"
@@ -169,3 +170,10 @@ func TestEnv(t *testing.T) {
 	err = testEnv.Stop()
 	g.Expect(err).NotTo(gomega.HaveOccurred())
 }
+
+func TestRand(t *testing.T) {
+
+	for i := 0; i < 10; i++ {
+		fmt.Println(rand.Int31())
+	}
+}

pkg/manager/controllers/rollout/expectation.go

@@ -56,7 +56,7 @@ func SetExpectedRevision(sts *appsv1.StatefulSet, podRevision map[string]string)
 
 func isUpdatedRevision(sts *appsv1.StatefulSet, po *corev1.Pod) bool {
 	expectedRevision := recentRevision(sts)
-	revision, _ := po.Labels[appsv1.StatefulSetRevisionLabel]
+	revision := po.Labels[appsv1.StatefulSetRevisionLabel]
 	return revision == expectedRevision
 }
 

pkg/manager/controllers/rollout/rollout_controller.go

@@ -298,7 +298,7 @@ func isLeader(po *corev1.Pod, identity string) bool {
 func updateRolloutAnno(sts *appsv1.StatefulSet, upgradedPods []string) (updated bool) {
 	msg, _ := json.Marshal(upgradedPods)
 	val := string(msg)
-	if upgradedPods == nil || len(upgradedPods) == 0 {
+	if len(upgradedPods) == 0 {
 		val = ""
 	}
 	if sts.Annotations == nil {