Skip to content

Add options argument in smartuiSnapshot #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Add options argument in smartuiSnapshot #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions packages/sdk-utils/src/smartui.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,9 @@ async function fetchDOMSerializer() {
}
}

async function postSnapshot(snapshotDOM, snapshotName, testType) {
async function postSnapshot(snapshot, testType) {
const data = JSON.stringify({
snapshot: {
dom: snapshotDOM,
name: snapshotName
},
snapshot,
testType
});

Expand Down
13 changes: 7 additions & 6 deletions packages/selenium-driver/src/smartui.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,24 @@
const utils = require('@lambdatest/sdk-utils');
const pkgName = require('../package.json').name;

async function smartuiSnapshot(driver, snapshotName) {
async function smartuiSnapshot(driver, name, options = {}) {
// TODO: check if driver is selenium webdriver object
if (!driver) throw new Error('An instance of the selenium driver object is required.');
if (!snapshotName) throw new Error('The `snapshotName` argument is required.');
if (!name) throw new Error('The `name` argument is required.');
if (!(await utils.isSmartUIRunning())) throw new Error('SmartUI server is not running.');
let log = utils.logger(pkgName);

try {
let resp = await utils.fetchDOMSerializer();
await driver.executeScript(resp.body.data.dom);

let { dom } = await driver.executeScript(options => ({
dom: SmartUIDOM.serialize(options)
let { dom, url } = await driver.executeScript(options => ({
dom: SmartUIDOM.serialize(options),
url: document.URL
}), {});

await utils.postSnapshot(dom.html, snapshotName, pkgName);
log.info(`Snapshot captured: ${snapshotName}`);
await utils.postSnapshot({url, name, dom, options}, pkgName);
log.info(`Snapshot captured: ${name}`);
} catch (error) {
throw new Error(error);
}
Expand Down