Skip to content

JS selenium release version 1.0.7 and sdk-utils 1.0.7 #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 8, 2025
Merged

JS selenium release version 1.0.7 and sdk-utils 1.0.7 #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0a71e27
add sessionId in snapshot option for selenium
parthlambdatest Feb 10, 2025
8e42dca
add default smartui server address
parthlambdatest Feb 10, 2025
02f1744
js selenium version 1.0.7
parthlambdatest Mar 8, 2025
6eaacb7
sdk utils version 1.0.7
parthlambdatest Mar 8, 2025
d99e16d
Merge pull request #42 from parthlambdatest/Dot-4397
sushobhit-lt Mar 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/sdk-utils/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@lambdatest/sdk-utils",
"version": "1.0.6",
"version": "1.0.7",
"description": "LambdaTest driver utils",
"main": "index.js",
"repository": {
Expand Down
6 changes: 4 additions & 2 deletions packages/sdk-utils/src/lib/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
function getSmartUIServerAddress() {
if (!process.env.SMARTUI_SERVER_ADDRESS) throw new Error('SmartUI server address not found');
return process.env.SMARTUI_SERVER_ADDRESS
if (!process.env.SMARTUI_SERVER_ADDRESS) {
return 'http://localhost:49152';
}
return process.env.SMARTUI_SERVER_ADDRESS;
}

module.exports = {
Expand Down
2 changes: 1 addition & 1 deletion packages/selenium/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@lambdatest/selenium-driver",
"version": "1.0.6",
"version": "1.0.7",
"description": "Selenium driver for all Lambdatest functionalities",
"main": "index.js",
"repository": {
Expand Down
8 changes: 8 additions & 0 deletions packages/selenium/src/smartui.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,14 @@ async function smartuiSnapshot(driver, name, options = {}) {
if (!name || typeof name !== 'string') throw new Error('The `name` argument is required.');
if (!(await utils.isSmartUIRunning())) throw new Error('Cannot find SmartUI server.');

// Append sessionId to options
try {
const sessionId = await driver.getSession().then(session => session.getId());
options.sessionId = sessionId;
} catch (error) {
console.log("Unable to append sessionId in snapshot options")
}

let log = utils.logger(pkgName);
try {
let resp = await utils.fetchDOMSerializer();
Expand Down