Merge pull request #252 from tidepool-org/ps2/LOOP-1750/alert-display-on-restart

Fix display of uncertain delivery alert on app restart

Author: ps2

Loop/Managers/DeliveryUncertaintyAlertManager.swift

@@ -39,8 +39,9 @@ class DeliveryUncertaintyAlertManager {
                 self.showUncertainDeliveryRecoveryView()
             }
             alert.addAction(action)
-            self.rootViewController.dismiss(animated: true)
-            self.rootViewController.present(alert, animated: animated)
+            self.rootViewController.dismiss(animated: false) {
+                self.rootViewController.present(alert, animated: animated)
+            }
             self.uncertainDeliveryAlert = alert
         }
     }

Loop/Managers/DeviceDataManager.swift

@@ -376,6 +376,14 @@ final class DeviceDataManager {
         return Manager.init(rawState: rawState) as? CGMManagerUI
     }
 
+    func checkDeliveryUncertaintyState() {
+        if let pumpManager = pumpManager, pumpManager.status.deliveryIsUncertain {
+            DispatchQueue.main.async {
+                self.deliveryUncertaintyAlertManager!.showAlert()
+            }
+        }
+    }
+    
     // Get HealthKit authorization for all of the stores
     func authorize(_ completion: @escaping () -> Void) {
         // Authorize all types at once for simplicity
@@ -483,12 +491,6 @@ private extension DeviceDataManager {
                                                     soundVendor: pumpManager)
 
             deliveryUncertaintyAlertManager = DeliveryUncertaintyAlertManager(pumpManager: pumpManager, rootViewController: rootViewController)
-            
-            if pumpManager.status.deliveryIsUncertain {
-                DispatchQueue.main.async {
-                    self.deliveryUncertaintyAlertManager!.showAlert()
-                }
-            }
         }
     }
 
@@ -711,11 +713,13 @@ extension DeviceDataManager: PumpManagerDelegate {
         // Update the pump-schedule based settings
         loopManager.setScheduleTimeZone(status.timeZone)
 
-        DispatchQueue.main.async {
-            if status.deliveryIsUncertain {
-                self.deliveryUncertaintyAlertManager?.showAlert()
-            } else {
-                self.deliveryUncertaintyAlertManager?.clearAlert()
+        if status.deliveryIsUncertain != oldStatus.deliveryIsUncertain {
+            DispatchQueue.main.async {
+                if status.deliveryIsUncertain {
+                    self.deliveryUncertaintyAlertManager?.showAlert()
+                } else {
+                    self.deliveryUncertaintyAlertManager?.clearAlert()
+                }
             }
         }
     }

Loop/View Controllers/StatusTableViewController.swift

@@ -157,6 +157,8 @@ final class StatusTableViewController: LoopChartsTableViewController {
         onscreen = true
 
         deviceManager.analyticsServicesManager.didDisplayStatusScreen()
+        
+        deviceManager.checkDeliveryUncertaintyState()
     }
 
     override func viewWillDisappear(_ animated: Bool) {