DoseMath.recommendTempBasalFromPredictedGlucose has a deceptive default value for allowPredictiveTempBelowRange

[bharat]

The default is for this value to be false, which can (and has) confused the reader to believe that this value is not set by default. But in actuality, this function is only called from:

Loop/Loop/Managers/LoopDataManager.swift

Line 549 in 00ce83d

allowPredictiveTempBelowRange: true

which forces the value to be true. This is a significant deviation from expectations unless you read the code carefully.

I propose that we make this value non-optional. It should be relatively easy - all we have to do is update the unit tests to force the value to be false anywhere that it's missing.

[bharat]

Jim (CrushingT1D) suggests doing research to see if/when this bit was flipped.
Jim also suggests dropping it from the docs, unless we want to mention that it's something that can be disabled.

[bharat]

This was merged in #297