Skip to content

Connection missing static methods #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Connection missing static methods #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/libraries/System.Net.Quic/ref/System.Net.Quic.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,13 +140,15 @@ namespace System.Net.Quic.Implementations.Managed
{
public sealed partial class ManagedQuicConnection : System.IAsyncDisposable
{
public ManagedQuicConnection(System.Net.Quic.QuicClientConnectionOptions options) { }
internal ManagedQuicConnection() { }
public static bool IsSupported { get { throw null; } }
public System.Net.IPEndPoint LocalEndPoint { get { throw null; } }
public System.Net.Security.SslApplicationProtocol NegotiatedApplicationProtocol { get { throw null; } }
public System.Security.Cryptography.X509Certificates.X509Certificate? RemoteCertificate { get { throw null; } }
public System.Net.EndPoint RemoteEndPoint { get { throw null; } }
public System.Threading.Tasks.ValueTask<System.Net.Quic.Implementations.Managed.ManagedQuicStream> AcceptInboundStreamAsync(System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
public System.Threading.Tasks.ValueTask CloseAsync(long errorCode, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
public static System.Threading.Tasks.ValueTask<System.Net.Quic.Implementations.Managed.ManagedQuicConnection> ConnectAsync(System.Net.Quic.QuicClientConnectionOptions options, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
public System.Threading.Tasks.ValueTask DisposeAsync() { throw null; }
public System.Threading.Tasks.ValueTask<System.Net.Quic.Implementations.Managed.ManagedQuicStream> OpenOutboundStreamAsync(System.Net.Quic.QuicStreamType type, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
}
Expand Down
13 changes: 8 additions & 5 deletions ...ries/System.Net.Quic/src/System/Net/Quic/Implementations/Managed/ManagedQuicConnection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
using System.Net.Quic.Implementations.Managed.Internal.Streams;
using System.Net.Quic.Implementations.Managed.Internal.Tracing;
using System.Net.Quic.Implementations.Managed.Internal.Tls;
using System.Net.Quic.Implementations.Managed.Internal.Tls.OpenSsl;
using System.Net.Security;
using System.Threading;
using System.Threading.Tasks;
Expand All @@ -28,6 +27,14 @@ namespace System.Net.Quic.Implementations.Managed
{
public sealed partial class ManagedQuicConnection : IAsyncDisposable
{
public static bool IsSupported => true;
public static async ValueTask<ManagedQuicConnection> ConnectAsync(QuicClientConnectionOptions options, CancellationToken cancellationToken = default)
{
var connection = new ManagedQuicConnection(options, TlsFactory.Default);
await connection.ConnectAsync(cancellationToken).ConfigureAwait(false);
return connection;
}

// This limit should ensure that if we can fit at least an ack frame into the packet,
private const int RequiredAllowanceForSending = 2 * ConnectionId.MaximumLength + 40;

Expand Down Expand Up @@ -229,10 +236,6 @@ internal void Ping()
/// </summary>
internal EndPoint UnsafeRemoteEndPoint => _remoteEndpoint;

public ManagedQuicConnection(QuicClientConnectionOptions options) : this(options, TlsFactory.Default)
{
}

// client constructor
internal ManagedQuicConnection(QuicClientConnectionOptions options, TlsFactory tlsFactory)
{
Expand Down
1 change: 0 additions & 1 deletion ...raries/System.Net.Quic/src/System/Net/Quic/Implementations/Managed/ManagedQuicListener.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
using System.Net.Quic.Implementations.Managed.Internal;
using System.Net.Quic.Implementations.Managed.Internal.Sockets;
using System.Net.Quic.Implementations.Managed.Internal.Tls;
using System.Net.Quic.Implementations.Managed.Internal.Tls.OpenSsl;
using System.Threading;
using System.Threading.Channels;
using System.Threading.Tasks;
Expand Down