Dev olu hardware wallet feature flag

[segun]

Explanation

Put the hardware wallet behind a feature flag and disable/remove ledger, trezor and gridplus connect buttons

• Fixes Put hardware wallet code and features in MV3 behind a feature flag #16677
• Blocked By: PR

Screenshots/Screencaps

Before

After

Manual Testing Steps

1. Start MetaMask in MV3 mode
2. Login
3. Click on Connect Hardware wallet
4. You should see the screen like in Before
5. Edit .metamaskrc
6. Add HARDWARE_WALLETS_MV3=1
7. Restart MetaMask in MV3 mode
8. Login
9. Click Connect Hardware wallet
10. You should see screen like in After
11. Restart MetaMask in MV2 mode
12. Login
13. Click Connect Hardware wallet
14. You should see screen like in Before

Pre-merge author checklist

• I've clearly explained:
  • What problem this PR is solving
  • How this problem was solved
  • How reviewers can test my changes
• Sufficient automated test coverage has been added

Pre-merge reviewer checklist

• Manual testing (e.g. pull and build branch, run in browser, test code being changed)
• PR is linked to the appropriate GitHub issue
• IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [3857747]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5, 6, 7
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2136 ± 102 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	96	336	133	49	23
		domContentLoaded	1764	2488	2110	211	101
		load	1799	2489	2136	212	102
		domInteractive	1764	2488	2110	211	101

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 290 bytes
• ui: 345 bytes
• common: 0 bytes

highlights:

storybook

• ui/pages/create-account/connect-hardware/select-hardware.stories.js

[metamaskbot]

Builds ready [944c0c8]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1702 ± 261 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	102	1692	213	340	163
		domContentLoaded	1170	3736	1683	549	264
		load	1195	3736	1702	544	261
		domInteractive	1170	3736	1683	549	264

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 269 bytes
• ui: 345 bytes
• common: 0 bytes

highlights:

storybook

• ui/pages/create-account/connect-hardware/select-hardware.stories.js

[metamaskbot]

Builds ready [d9af3fe]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1259 ± 84 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	94	140	117	12	6
		domContentLoaded	1041	1603	1224	172	83
		load	1046	1604	1259	175	84
		domInteractive	1041	1603	1224	172	83

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 269 bytes
• ui: 345 bytes
• common: 0 bytes

highlights:

storybook

• ui/pages/create-account/connect-hardware/select-hardware.stories.js

[danjm]

setLedgerTransportPreference in the metamask-controller should not be called, or should return immediately, if canUseHardwareWallets() is false

[danjm]

This was resolved in #17354