Cleanup some uses of Dimension

closes #4011

Author: Wide-Cat

src/main/java/meteordevelopment/meteorclient/systems/modules/render/Breadcrumbs.java

@@ -73,6 +73,8 @@ public void onDeactivate() {
 
     @EventHandler
     private void onTick(TickEvent.Post event) {
+        if (!mc.player.isLoaded()) return;
+
         if (lastDimension != mc.world.getDimension()) {
             for (Section sec : sections) sectionPool.free(sec);
             sections.clear();
@@ -130,9 +132,5 @@ public void set2() {
             y2 = (float) mc.player.getY();
             z2 = (float) mc.player.getZ();
         }
-
-        public void render(Render3DEvent event) {
-            event.renderer.line(x1, y1, z1, x2, y2, z2, color.get());
-        }
     }
 }

src/main/java/meteordevelopment/meteorclient/systems/modules/render/LogoutSpots.java

@@ -19,11 +19,11 @@
 import meteordevelopment.meteorclient.utils.render.NametagUtils;
 import meteordevelopment.meteorclient.utils.render.color.Color;
 import meteordevelopment.meteorclient.utils.render.color.SettingColor;
-import meteordevelopment.meteorclient.utils.world.Dimension;
 import meteordevelopment.orbit.EventHandler;
 import net.minecraft.client.network.PlayerListEntry;
 import net.minecraft.entity.Entity;
 import net.minecraft.entity.player.PlayerEntity;
+import net.minecraft.world.dimension.DimensionType;
 import org.joml.Vector3d;
 
 import java.util.ArrayList;
@@ -98,7 +98,7 @@ public class LogoutSpots extends Module {
     private final List<PlayerEntity> lastPlayers = new ArrayList<>();
 
     private int timer;
-    private Dimension lastDimension;
+    private DimensionType lastDimension;
 
     public LogoutSpots() {
         super(Categories.Render, "logout-spots", "Displays a box where another player has logged out at.");
@@ -111,7 +111,7 @@ public void onActivate() {
         updateLastPlayers();
 
         timer = 10;
-        lastDimension = PlayerUtils.getDimension();
+        lastDimension = mc.world.getDimension();
     }
 
     @Override
@@ -170,7 +170,7 @@ private void onTick(TickEvent.Post event) {
             timer--;
         }
 
-        Dimension dimension = PlayerUtils.getDimension();
+        DimensionType dimension = mc.world.getDimension();
         if (dimension != lastDimension) players.clear();
         lastDimension = dimension;
     }

src/main/java/meteordevelopment/meteorclient/systems/modules/render/VoidESP.java

@@ -12,9 +12,7 @@
 import meteordevelopment.meteorclient.systems.modules.Categories;
 import meteordevelopment.meteorclient.systems.modules.Module;
 import meteordevelopment.meteorclient.utils.misc.Pool;
-import meteordevelopment.meteorclient.utils.player.PlayerUtils;
 import meteordevelopment.meteorclient.utils.render.color.SettingColor;
-import meteordevelopment.meteorclient.utils.world.Dimension;
 import meteordevelopment.meteorclient.utils.world.Dir;
 import meteordevelopment.orbit.EventHandler;
 import net.minecraft.block.Block;
@@ -23,6 +21,7 @@
 import net.minecraft.util.math.Direction;
 import net.minecraft.world.chunk.Chunk;
 import net.minecraft.world.chunk.ChunkStatus;
+import net.minecraft.world.dimension.DimensionTypes;
 
 import java.util.ArrayList;
 import java.util.List;
@@ -102,7 +101,7 @@ public VoidESP() {
     @EventHandler
     private void onTick(TickEvent.Post event) {
         voidHoles.clear();
-        if (PlayerUtils.getDimension() == Dimension.End) return;
+        if (mc.world.getDimensionEntry() == DimensionTypes.THE_END) return;
 
         int px = mc.player.getBlockPos().getX();
         int pz = mc.player.getBlockPos().getZ();
@@ -114,7 +113,7 @@ private void onTick(TickEvent.Post event) {
                 if (isHole(blockPos, false)) voidHoles.add(voidHolePool.get().set(blockPos.set(x, mc.world.getBottomY(), z), false));
 
                 // Check for nether roof
-                if (netherRoof.get() && PlayerUtils.getDimension() == Dimension.Nether) {
+                if (netherRoof.get() && mc.world.getDimensionEntry() == DimensionTypes.THE_NETHER) {
                     blockPos.set(x, 127, z);
                     if (isHole(blockPos, true)) voidHoles.add(voidHolePool.get().set(blockPos.set(x, 127, z), true));
                 }

src/main/java/meteordevelopment/meteorclient/systems/modules/render/blockesp/BlockESP.java

@@ -17,15 +17,14 @@
 import meteordevelopment.meteorclient.systems.modules.Categories;
 import meteordevelopment.meteorclient.systems.modules.Module;
 import meteordevelopment.meteorclient.utils.Utils;
-import meteordevelopment.meteorclient.utils.player.PlayerUtils;
 import meteordevelopment.meteorclient.utils.render.color.RainbowColors;
 import meteordevelopment.meteorclient.utils.render.color.SettingColor;
-import meteordevelopment.meteorclient.utils.world.Dimension;
 import meteordevelopment.orbit.EventHandler;
 import net.minecraft.block.Block;
 import net.minecraft.util.math.BlockPos;
 import net.minecraft.util.math.ChunkPos;
 import net.minecraft.world.chunk.Chunk;
+import net.minecraft.world.dimension.DimensionType;
 
 import java.util.Iterator;
 import java.util.List;
@@ -83,7 +82,7 @@ public class BlockESP extends Module {
     private final Set<ESPGroup> groups = new ReferenceOpenHashSet<>();
     private final ExecutorService workerThread = Executors.newSingleThreadExecutor();
 
-    private Dimension lastDimension;
+    private DimensionType lastDimension;
 
     public BlockESP() {
         super(Categories.Render, "block-esp", "Renders specified blocks through walls.", "search");
@@ -102,7 +101,7 @@ public void onActivate() {
             searchChunk(chunk);
         }
 
-        lastDimension = PlayerUtils.getDimension();
+        lastDimension = mc.world.getDimension();
     }
 
     @Override
@@ -227,10 +226,9 @@ private void onBlockUpdate(BlockUpdateEvent event) {
 
     @EventHandler
     private void onPostTick(TickEvent.Post event) {
-        Dimension dimension = PlayerUtils.getDimension();
+        DimensionType dimension = mc.world.getDimension();
 
         if (lastDimension != dimension) onActivate();
-
         lastDimension = dimension;
     }
 

src/main/java/meteordevelopment/meteorclient/utils/player/PlayerUtils.java

@@ -204,7 +204,7 @@ else if (entity instanceof PlayerEntity player && !Friends.get().isFriend(player
             }
 
             // Check for beds if in nether
-            if (PlayerUtils.getDimension() != Dimension.Overworld) {
+            if (!mc.world.getDimension().bedWorks()) {
                 for (BlockEntity blockEntity : Utils.blockEntities()) {
                     BlockPos bp = blockEntity.getPos();
                     Vec3d pos = new Vec3d(bp.getX(), bp.getY(), bp.getZ());