Skip to content

Conversation

@mburleigh
Copy link
Contributor

Simplify and separate code based on @chrmarti comments on my original PR (#47).

This PR adds the user setting & implementation to open command results in separate tabs.

Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. Please see my inline comments.

@chrmarti
Copy link
Contributor

Testing revealed that the code would fail replacing content when the editor is already hidden by the next one. I'm adding a change to use WorkspaceEdit to cover that case. Thanks!

@chrmarti chrmarti merged commit 5986bd8 into microsoft:master Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants