Skip to content

Commit d724df4

Browse files
committed
test: do not explicitly pass temperature=0 to select greedy sampling
Signed-off-by: ixlmar <[email protected]>
1 parent d7b9ded commit d724df4

File tree

3 files changed

+2
-6
lines changed

3 files changed

+2
-6
lines changed

tensorrt_llm/evaluate/json_mode_eval.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,7 @@ def generate_samples(self) -> Iterable[tuple]:
6464
schema["x-guidance"] = {"lenient": True}
6565
schema = json.dumps(schema)
6666
sampling_args = {
67-
"guided_decoding": GuidedDecodingParams(json=schema),
68-
"temperature": 0,
67+
"guided_decoding": GuidedDecodingParams(json=schema)
6968
}
7069
yield sample["prompt"], sampling_args, sample["completion"], sample[
7170
"schema"]

tensorrt_llm/evaluate/mmlu.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ def generate_samples(self) -> Iterable[tuple]:
219219
include_answer=False)
220220
prompt = train_prompt + prompt_end
221221
label = test_df.iloc[i, test_df.shape[1] - 1]
222-
yield prompt, {"temperature": 0}, label, subject
222+
yield prompt, None, label, subject
223223

224224
def compute_score(self, outputs: List[RequestOutput], references: List[str],
225225
subjects: List[str]) -> float:

tests/unittest/llmapi/apps/_test_openai_misc.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,12 +94,9 @@ async def test_request_cancellation(server: RemoteOpenAIServer,
9494
# Request about 2 million tokens
9595
for _ in range(200):
9696
task = asyncio.create_task(
97-
# FIXME: Some requests complete quickly without temperature=0,
98-
# despite min_tokens being specified, cf. https://nvbugs/5513423
9997
client.chat.completions.create(messages=chat_input,
10098
model=model_name,
10199
max_tokens=10000,
102-
temperature=0,
103100
extra_body={"min_tokens": 10000}))
104101
tasks.append(task)
105102

0 commit comments

Comments
 (0)