Skip to content

Conversation

@xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Aug 4, 2025

waive failed cases.

Summary by CodeRabbit

  • Tests
    • Added seven new test cases to the integration test skip list, each referencing a specific bug tracking URL.

@xinhe-nv xinhe-nv requested review from LarryXFly and crazydemo August 4, 2025 02:01
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 4, 2025

📝 Walkthrough

Walkthrough

Seven new test cases were added to the integration test skip list in tests/integration/test_lists/waives.txt. These entries pertain to specific tests for Llama3 and Phi4 models and reference corresponding bug tracking URLs. No existing entries were modified or removed.

Changes

Cohort / File(s) Change Summary
Integration Test Skip List Updates
tests/integration/test_lists/waives.txt
Added seven new test cases to the skip list for Llama3 and Phi4 models, each with a bug tracking URL.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between af31f40 and ad7f112.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • tests/integration/test_lists/waives.txt
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20250804_LLM_FUNCTION_TEST_1058 branch from a262df2 to 2d45d4a Compare August 4, 2025 04:19
@xinhe-nv xinhe-nv marked this pull request as ready for review August 4, 2025 04:19
@xinhe-nv xinhe-nv changed the title Draft: test: [CI] Add failed cases into waives.txt [None][fix] Add failed cases into waives.txt Aug 4, 2025
@xinhe-nv
Copy link
Collaborator Author

xinhe-nv commented Aug 4, 2025

/bot run

@xinhe-nv xinhe-nv enabled auto-merge (squash) August 4, 2025 04:20
@tensorrt-cicd
Copy link
Collaborator

PR_Github #13922 [ run ] triggered by Bot

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20250804_LLM_FUNCTION_TEST_1058 branch from 2d45d4a to 5db5f93 Compare August 4, 2025 06:06
@tensorrt-cicd
Copy link
Collaborator

PR_Github #13922 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #10484 completed with status: 'FAILURE'

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20250804_LLM_FUNCTION_TEST_1058 branch from 5db5f93 to af31f40 Compare August 4, 2025 06:15
@xinhe-nv
Copy link
Collaborator Author

xinhe-nv commented Aug 4, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #13942 [ run ] triggered by Bot

@xinhe-nv xinhe-nv changed the title [None][fix] Add failed cases into waives.txt [TRTQA-2920][fix] Add failed cases into waives.txt Aug 4, 2025
@tensorrt-cicd
Copy link
Collaborator

PR_Github #13942 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #10504 completed with status: 'FAILURE'

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20250804_LLM_FUNCTION_TEST_1058 branch from af31f40 to 3384d65 Compare August 4, 2025 12:17
@xinhe-nv
Copy link
Collaborator Author

xinhe-nv commented Aug 4, 2025

/bot run

1 similar comment
@xinhe-nv
Copy link
Collaborator Author

xinhe-nv commented Aug 4, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #13993 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #13994 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #13993 [ run ] completed with state ABORTED

Signed-off-by: Xin He (SW-GPU) <[email protected]>
@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20250804_LLM_FUNCTION_TEST_1058 branch from 3384d65 to ad7f112 Compare August 4, 2025 12:59
@xinhe-nv
Copy link
Collaborator Author

xinhe-nv commented Aug 4, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #13994 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #10544 completed with status: 'FAILURE'

@xinhe-nv
Copy link
Collaborator Author

xinhe-nv commented Aug 4, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #14003 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #14004 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #14003 [ run ] completed with state ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #14004 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #10554 completed with status: 'FAILURE'

@LarryXFly LarryXFly disabled auto-merge August 5, 2025 02:26
@xinhe-nv xinhe-nv enabled auto-merge (squash) August 5, 2025 02:35
@LarryXFly LarryXFly disabled auto-merge August 5, 2025 02:41
@LarryXFly LarryXFly merged commit fe3d607 into NVIDIA:main Aug 5, 2025
3 checks passed
@xinhe-nv xinhe-nv deleted the user/qa/post_update_waive_20250804_LLM_FUNCTION_TEST_1058 branch August 5, 2025 02:44
lancelly pushed a commit to lancelly/TensorRT-LLM that referenced this pull request Aug 6, 2025
Signed-off-by: Xin He (SW-GPU) <[email protected]>
Co-authored-by: Larry <[email protected]>
Signed-off-by: Lanyu Liao <[email protected]>
jain-ria pushed a commit to jain-ria/TensorRT-LLM that referenced this pull request Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants