feat(config): logRuntimeDetail boolean can toggle verbose runtime logs

Author: NathanWalker

NativeScript/runtime/Interop.mm

@@ -1487,9 +1487,6 @@
 // MARK: - Debug Messages for the runtime
 
 void ExecuteWriteValueValidationsAndStopExecutionAndLogStackTrace(Local<Context> context, const TypeEncoding* typeEncoding, void* dest, Local<Value> arg) {
-    if (!RuntimeConfig.IsDebug) {
-        return;
-    }
     Isolate* isolate = context->GetIsolate();
     std::string destName = typeEncoding->details.interfaceDeclarationReference.name.valuePtr();
     Local<Value> originArg = arg;
@@ -1524,32 +1521,35 @@ bool IsTypeEncondingHandldedByDebugMessages(const TypeEncoding* typeEncoding) {
 }
 
 void LogWriteValueTraceMessage(Local<Context> context, const TypeEncoding* typeEncoding, void* dest, Local<Value> arg) {
-    if (!RuntimeConfig.IsDebug) {
-        return;
-    }
     Isolate* isolate = context->GetIsolate();
     std::string destName = typeEncoding->details.interfaceDeclarationReference.name.valuePtr();
     std::string originName = tns::ToString(isolate, arg);
     if (originName == "") {
         // empty string
         originName = "\"\"";
     }
+    // NOTE: stringWithFormat is slow, perhaps use different c string concatenation?
     NSString* message = [NSString stringWithFormat:@"Interop::WriteValue: from {%s} to {%s}", originName.c_str(), destName.c_str()];
     Log(@"%@", message);
 }
 
 void Interop::ExecuteWriteValueDebugValidationsIfInDebug(Local<Context> context, const TypeEncoding* typeEncoding, void* dest, Local<Value> arg) {
+
     if (!RuntimeConfig.IsDebug) {
         return;
     }
-    if (arg.IsEmpty() || arg->IsNullOrUndefined()) {
-        return;
-    }
-    if (IsTypeEncondingHandldedByDebugMessages(typeEncoding)) {
-        return;
+    id value = Runtime::GetAppConfigValue("logRuntimeDetail");
+    bool logRuntimeDetail = value ? [value boolValue] : false;
+    if (logRuntimeDetail) {
+        if (arg.IsEmpty() || arg->IsNullOrUndefined()) {
+            return;
+        }
+        if (IsTypeEncondingHandldedByDebugMessages(typeEncoding)) {
+            return;
+        }
+        LogWriteValueTraceMessage(context, typeEncoding, dest, arg);
+        ExecuteWriteValueValidationsAndStopExecutionAndLogStackTrace(context, typeEncoding, dest, arg);
     }
-    LogWriteValueTraceMessage(context, typeEncoding, dest, arg);
-    ExecuteWriteValueValidationsAndStopExecutionAndLogStackTrace(context, typeEncoding, dest, arg);
 }
 
 }

NativeScript/runtime/MetadataBuilder.mm

@@ -11,6 +11,7 @@
 #include "Worker.h"
 #include "Caches.h"
 #include "Tasks.h"
+#include "Runtime.h"
 #include "RuntimeConfig.h"
 
 using namespace v8;
@@ -812,13 +813,18 @@
     // TODO: Find out if the isMethodCallback property can be determined based on a UITableViewController.prototype.viewDidLoad.call(this) or super.viewDidLoad() call
 
     if (RuntimeConfig.IsDebug) {
-        NSString* message = [NSString stringWithFormat:@"MetadataBuilder::InvokeMethod class {%s}, selector {%s}, isInitializer {%s}, type {%s}, lib {%s}",
-                             containingClass.c_str(),
-                             meta->selectorAsString(),
-                             meta->isInitializer() ? "true":"false",
-                             meta->typeName(),
-                             meta->topLevelModule()->getName()];
-        Log(@"%@", message);
+        id value = Runtime::GetAppConfigValue("logRuntimeDetail");
+        bool logRuntimeDetail = value ? [value boolValue] : false;
+        if (logRuntimeDetail) {
+            // NOTE: stringWithFormat is slow, perhaps use different c string concatenation?
+            NSString* message = [NSString stringWithFormat:@"MetadataBuilder::InvokeMethod: class {%s}, selector {%s}, isInitializer {%s}, type {%s}, lib {%s}",
+                                containingClass.c_str(),
+                                meta->selectorAsString(),
+                                meta->isInitializer() ? "true":"false",
+                                meta->typeName(),
+                                meta->topLevelModule()->getName()];
+            Log(@"%@", message);
+        }
     }
 
     try {