From d8c17167a5cc8662ee2512afea3087387ba1660f Mon Sep 17 00:00:00 2001 From: Acksell Date: Sat, 16 Jul 2022 19:06:42 +0200 Subject: [PATCH 1/2] MLKitView typing: Hide overriden on-function --- packages/mlkit-core/index.d.ts | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/packages/mlkit-core/index.d.ts b/packages/mlkit-core/index.d.ts index 048ed0d..9cb5171 100644 --- a/packages/mlkit-core/index.d.ts +++ b/packages/mlkit-core/index.d.ts @@ -43,6 +43,11 @@ export declare class MLKitView extends MLKitViewBase { requestCameraPermission(): Promise; hasCameraPermission(): boolean; on(event: 'detection', callback: (args: DetectionEvent) => void, thisArg?: any); + // Needed when 'on' method is overriden. + /** + * @hidden + */ + on(eventNames: string, callback: (data: EventData) => void, thisArg?: any): void; } export function detectWithStillImage(image: any, options?: StillImageDetectionOptions): Promise<{ [key: string]: any }>; From 413e5fff8e847b6b424f42aebcd746c8ca90e3be Mon Sep 17 00:00:00 2001 From: Acksell Date: Sat, 16 Jul 2022 19:24:53 +0200 Subject: [PATCH 2/2] fix indentation --- packages/mlkit-core/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/mlkit-core/index.d.ts b/packages/mlkit-core/index.d.ts index 9cb5171..d320328 100644 --- a/packages/mlkit-core/index.d.ts +++ b/packages/mlkit-core/index.d.ts @@ -47,7 +47,7 @@ export declare class MLKitView extends MLKitViewBase { /** * @hidden */ - on(eventNames: string, callback: (data: EventData) => void, thisArg?: any): void; + on(eventNames: string, callback: (data: EventData) => void, thisArg?: any): void; } export function detectWithStillImage(image: any, options?: StillImageDetectionOptions): Promise<{ [key: string]: any }>;