Skip to content

Commit 255faaf

Browse files
caneGuysrowen
authored andcommitted
[SPARK-26751][SQL] Fix memory leak when statement run in background and throw exception which is not HiveSQLException
## What changes were proposed in this pull request? When we run in background and we get exception which is not HiveSQLException, we may encounter memory leak since handleToOperation will not removed correctly. The reason is below: 1. When calling operation.run() in HiveSessionImpl#executeStatementInternal we throw an exception which is not HiveSQLException 2. Then the opHandle generated by SparkSQLOperationManager will not be added into opHandleSet of HiveSessionImpl , and operationManager.closeOperation(opHandle) will not be called 3. When we close the session we will also call operationManager.closeOperation(opHandle),since we did not add this opHandle into the opHandleSet. For the reasons above,the opHandled will always in SparkSQLOperationManager#handleToOperation,which will cause memory leak. More details and a case has attached on https://issues.apache.org/jira/browse/SPARK-26751 This patch will always throw HiveSQLException when running in background ## How was this patch tested? Exist UT Closes apache#23673 from caneGuy/zhoukang/fix-hivesessionimpl-leak. Authored-by: zhoukang <[email protected]> Signed-off-by: Sean Owen <[email protected]>
1 parent dfb8809 commit 255faaf

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ private[hive] class SparkExecuteStatementOperation(
205205
case NonFatal(e) =>
206206
logError(s"Error executing query in background", e)
207207
setState(OperationState.ERROR)
208-
throw e
208+
throw new HiveSQLException(e)
209209
}
210210
}
211211
}

0 commit comments

Comments
 (0)