[go] Bug: Invalid generated code for client when apiKey in cookie is used.

[dmascialino]

Description

The client code generated for go, when cookie option is used for apiKey (as described here: https://swagger.io/docs/specification/authentication/api-keys/ ) is broken.

openapi-generator version

3.3.4-SNAPSHOT (commit: 33016f2 )

OpenAPI declaration file content or url

https://gist.github.com/dmascialino/016fd42979b4736658d91a303404dba9

Command line used for generation

openapi-generator generate -i api_defenition.yaml -g go -o openapi

Steps to reproduce

go build ./openapi
# openapi_example/openapi
openapi/api_default.go:67:8: key declared and not used

[qmuntal]

With the fix applied in #1601 I can only specify am apiKey cookie per ApiClient by using a cookiejar. I have a use case where I need to specify the cookie per request, as my application acts as a proxy used by multiple users, and the only solution I have now is to create a new APIClient on each incoming request, which is very inefficient.
Go Technincal committee: @antihax @bvwells @grokify @kemokemo

[antihax]

Agree, this should flow like OAuth2.

Short term, you can add the API key to the Request.Context and use a middleware to set the cookie header.

[antihax]

Just went back and looked.

Changes from #1601 probably needs to be reverted and the cookie applied in the following area.

{{#isApiKey}}
	if ctx != nil {
		// API Key Authentication
		if auth, ok := ctx.Value(ContextAPIKey).(APIKey); ok {
			var key string
			if auth.Prefix != "" {
				key = auth.Prefix + " " + auth.Key
			} else {
				key = auth.Key
			}
			{{#isKeyInHeader}}
			localVarHeaderParams["{{keyParamName}}"] = key
			{{/isKeyInHeader}}
			{{#isKeyInQuery}}
			localVarQueryParams.Add("{{keyParamName}}", key)
			{{/isKeyInQuery}}
			{{#isKeyInCookie}}
			/// ## set cookie here ##
			{{/isKeyInCookie}}

		}
	}
{{/isApiKey}}