[Kotlin][Client] Added supporting Retrofit2(RxJava/RxJava2/Coroutines) #5750

kuFEAR · 2020-03-29T22:08:33Z

Added supporting Retrofit2(RxJava/RxJava2/Coroutines) for Kotlin client code generator

PR checklist

Read the contribution guidelines.
If contributing template-only or documentation-only changes which will change sample output, build the project before.
Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@jimschubert @dr4ke616 @karismann @Zomzog @andrewemery @4brunu

…ode generator

…otlin

…ody.Part annotation

wing328 · 2020-04-02T04:17:33Z

Please merge the latest master into this branch to resolve the CircleCI failure.

Merge with base repository

…tines

kuFEAR · 2020-04-02T09:45:35Z

hm, merge is not helped

Add dependencies for rxJava/rxJava2 and rx retrofit's adapter.

kuFEAR · 2020-04-02T19:57:28Z

...napi3/client/petstore/kotlin/src/main/kotlin/org/openapitools/client/models/NullableClass.kt

-: Serializable 
-
-{
+) : kotlin.mapOf&lt;String, kotlin.Any&gt;, Serializable {


Looks like broken for generics somewhere before my changes

…coroutines

4brunu · 2020-04-03T07:54:45Z

Currently we have two open PR that implement coroutines support.
#5697
@wing328 could you please help with this? How should we handle this?

This reverts commit 9de4d0b

kuFEAR · 2020-05-12T05:59:07Z

#5600 Fixed encoding from 3. using {{{parent}}}

…coroutines

kuFEAR · 2020-05-12T08:47:41Z

[FIXED]
I fixed adding empty braces for inheritance from map/array by {{#isMapModel}}(){{/isMapModel}}{{#isArrayModel}}(){{/isArrayModel}}, I don't know is correct approach or not, but it works)

4brunu · 2020-05-12T09:00:35Z

modules/openapi-generator/src/main/resources/kotlin-client/interface_opt_var.mustache

    {{#moshi}}
    @Json(name = "{{{vendorExtensions.x-base-name-literal}}}")
    {{/moshi}}
-    {{#gson}}


@kuFEAR Why did you remove gson from here?

#5750 (comment) 1.

Gson @SerializedName target only for method and fields
@target({ElementType.FIELD, ElementType.METHOD}) and Kotlin interface fields is not yet determined as field by kotlin compiler, I saw error message there

4brunu · 2020-05-12T09:00:59Z

modules/openapi-generator/src/main/resources/kotlin-client/interface_req_var.mustache

    {{#moshi}}
    @Json(name = "{{{vendorExtensions.x-base-name-literal}}}")
    {{/moshi}}
-    {{#gson}}


@kuFEAR same here

#5750 (comment) 1.

I have an idea add @get:SerializedName("field")

If that works, it would be nice, because I use Gson on my projects

…SerializedName as for Jackson

kuFEAR · 2020-05-13T08:53:08Z

[main] ERROR org.openapitools.codegen.languages.MysqlSchemaCodegen - Invalid database name. '12345' cannot be used as MySQL identifier. Escaped value '12345_db' will be used instead.
[main] ERROR org.openapitools.codegen.DefaultCodegen - `null` (map property) does not have a proper inner type defined. Default to type:string
[main] ERROR org.openapitools.codegen.DefaultCodegen - ERROR! Not handling  class QueryParameter {
    class Parameter {
        name: limit
        in: null
        description: this is a description
        required: true
        deprecated: null
        allowEmptyValue: null
        style: null
        explode: null
        allowReserved: null
        schema: null
        examples: null
        example: null
        content: null
        $ref: null
    }
    in: query
} as Body Parameter at the moment
[main] ERROR org.openapitools.codegen.DefaultCodegen - `null` (map property) does not have a proper inner type defined. Default to type:string
[main] ERROR org.openapitools.codegen.DefaultCodegen - body in fromRequestBody cannot be null!
[main] ERROR org.openapitools.codegen.utils.ModelUtils - Schema cannot be null in isFreeFormObject check
[main] ERROR o.o.c.config.CodegenConfigurator - Unexpected character ('-' (code 45)) in numeric value: expected digit (0-9) to follow minus sign, for valid numeric value
 at [Source: (File); line: 1, column: 3]
[main] ERROR o.o.c.config.CodegenConfigurator - Unexpected character ('-' (code 45)) in numeric value: expected digit (0-9) to follow minus sign, for valid numeric value
 at [Source: (File); line: 1, column: 3]

[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (test) on project PythonFlaskConnexionTests: Command execution failed. Process exited with an error: 2 (Exit value: 2) -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <args> -rf :PythonFlaskConnexionTests

This error is related to my PR?

…coroutines

4brunu · 2020-05-13T08:58:34Z

I don't think so, it seems to be related to python, and the master branch was failing with the same error.

kuFEAR · 2020-05-13T09:00:20Z

I don't think so, it seems to be related to python, and the master branch was failing with the same error.

ok, thanks

wing328 · 2020-05-13T09:58:39Z

The issue has been fixed in the master. Please merge the latest master into this branch to fix the issue.

…coroutines

kuFEAR · 2020-05-13T13:35:22Z

now it fails on sudo apt-get install elixir

…coroutines

wing328 · 2020-05-14T12:46:29Z

Restarted the CI job. Let's see how it goes.

wing328 · 2020-05-18T08:20:43Z

Tested the kotlin retrofit2 samples and no longer encounter the issue.

Added support Retrofit2(RxJava/RxJava2/Coroutines) to Kotlin client c…

7b543ec

…ode generator

kuFEAR requested a review from jimschubert as a code owner March 29, 2020 22:08

kuFEAR added 3 commits March 30, 2020 01:14

Added generated samples for Retrofit2(RxJava/RxJava2/Coroutines) on K…

49ac48c

…otlin

Fixed generating retrofit2 without Rx/Coroutines

8b074f4

Fixed MultipartBody template, remove redundant space after MultipartB…

87745a9

…ody.Part annotation

kuFEAR changed the title ~~Added supporting Retrofit2(RxJava/RxJava2/Coroutines) for Kotlin client~~ [Kotlin][Client] Added supporting Retrofit2(RxJava/RxJava2/Coroutines) Mar 31, 2020

kuFEAR mentioned this pull request Mar 31, 2020

[REQ] [Kotlin] client generator support for coroutines and suspend functions #5076

Open

kuFEAR and others added 2 commits April 2, 2020 09:11

Merge pull request #1 from OpenAPITools/master

684c966

Merge with base repository

Merge remote-tracking branch 'origin/master' into kotlin-rx-rx2-corou…

82d9a88

…tines

kuFEAR added 13 commits April 2, 2020 13:01

Fix documentation diff.

22f96f8

Fix generating build.gradle file for samples.

602ae5a

Add dependencies for rxJava/rxJava2 and rx retrofit's adapter.

Update generated sample with rx dependencies

8e5434b

Update generated sample with coroutines

d6b568d

Update generated sample with RxJava 2 dependencies

cd40923

Update and refactoring scripts for sample generation

42b0abb

Update generated sample code

7f91ea8

revert changes by mistake

7966a4c

revert changes by mistake OpenAPITools#2

1d442c1

Fix return type for first RxJava

f621481

Add RxJavaCallAdapterFactory to ApiClient scheme for RxJava 1/2

62bac13

Fix script loggin

21933ea

Update generated code for RxJava 1/2

670346a

kuFEAR commented Apr 2, 2020

View reviewed changes

kuFEAR added 2 commits April 3, 2020 00:49

Fix kotlin.md documentation by script export_docs_generators.sh

83a5e3c

Merge remote-tracking branch 'base_origin/master' into kotlin-rx-rx2-…

ab87d13

…coroutines

kuFEAR added 2 commits April 8, 2020 09:31

Update Kotlin samples project in pom.xml

9de4d0b

Revert "Update Kotlin samples project in pom.xml"

d132182

This reverts commit 9de4d0b

kuFEAR added 5 commits May 11, 2020 15:46

Update Kotlin samples project for kotlin-jvm-*

031dce2

Update Kotlin readme.md documentations

c26da0f

Update Kotlin client sample changes

4ece587

Fixed encoding braces for generics model

9b42770

Update Kotlin client sample changes

348edf6

kuFEAR added 4 commits May 12, 2020 09:26

Merge remote-tracking branch 'base_origin/master' into kotlin-rx-rx2-…

9e600cc

…coroutines

Update Kotlin client sample after merge with master

19ebd7c

Fixed adding empty braces for inherit from Map/Array

4f73f0a

Update sample model after last fix with empty braces

a1477f4

4brunu reviewed May 12, 2020

View reviewed changes

kuFEAR added 2 commits May 12, 2020 13:14

Revert adding @SerializedName to Kotlin interface fields through @get:…

313c1ce

…SerializedName as for Jackson

Update Kotlin client samples with adding @get:SerializedName

6b3cc8f

Merge remote-tracking branch 'base_origin/master' into kotlin-rx-rx2-…

fe094e5

…coroutines

Merge remote-tracking branch 'base_origin/master' into kotlin-rx-rx2-…

dc36be7

…coroutines

Merge remote-tracking branch 'base_origin/master' into kotlin-rx-rx2-…

028b9a5

…coroutines

wing328 approved these changes May 18, 2020

View reviewed changes

wing328 merged commit eefcd62 into OpenAPITools:master May 18, 2020

wing328 mentioned this pull request May 20, 2020

Enhancement/kotlin/retrofit2 #5697

Closed

5 tasks

kuFEAR deleted the kotlin-rx-rx2-coroutines branch May 23, 2020 11:01

wing328 added this to the 5.0.0 milestone Jul 3, 2020

Uh oh!

[Kotlin][Client] Added supporting Retrofit2(RxJava/RxJava2/Coroutines) #5750

[Kotlin][Client] Added supporting Retrofit2(RxJava/RxJava2/Coroutines) #5750

Uh oh!

Conversation

kuFEAR commented Mar 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR checklist

Uh oh!

wing328 commented Apr 2, 2020

Uh oh!

kuFEAR commented Apr 2, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

4brunu commented Apr 3, 2020

Uh oh!

kuFEAR commented May 12, 2020

Uh oh!

kuFEAR commented May 12, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kuFEAR commented May 13, 2020

Uh oh!

4brunu commented May 13, 2020

Uh oh!

kuFEAR commented May 13, 2020

Uh oh!

wing328 commented May 13, 2020

Uh oh!

kuFEAR commented May 13, 2020

Uh oh!

wing328 commented May 14, 2020

Uh oh!

wing328 commented May 18, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kuFEAR commented Mar 29, 2020 •

edited

Loading