Squiz/DocCommentAlignment: update for properties with asymmetric visibility

Prevent false negatives for the "incorrect space before star" error.

Includes tests.

Author: jrfnl

src/Standards/Squiz/Sniffs/Commenting/DocCommentAlignmentSniff.php

@@ -52,7 +52,7 @@ public function process(File $phpcsFile, $stackPtr)
     {
         $tokens = $phpcsFile->getTokens();
 
-        // We are only interested in function/class/interface doc block comments.
+        // We are only interested in function/class/interface/enum/property/const doc block comments.
         $ignore = Tokens::$emptyTokens;
         if ($phpcsFile->tokenizerType === 'JS') {
             $ignore[] = T_EQUAL;
@@ -61,15 +61,14 @@ public function process(File $phpcsFile, $stackPtr)
         }
 
         $nextToken = $phpcsFile->findNext($ignore, ($stackPtr + 1), null, true);
-        $ignore    = [
+
+        $ignore  = Tokens::$scopeModifiers;
+        $ignore += [
             T_CLASS     => true,
             T_INTERFACE => true,
             T_ENUM      => true,
             T_ENUM_CASE => true,
             T_FUNCTION  => true,
-            T_PUBLIC    => true,
-            T_PRIVATE   => true,
-            T_PROTECTED => true,
             T_STATIC    => true,
             T_ABSTRACT  => true,
             T_FINAL     => true,

src/Standards/Squiz/Tests/Commenting/DocCommentAlignmentUnitTest.inc

@@ -114,3 +114,20 @@ final class FinalClassWithFinalProp
       */
     final $property = 10;
 }
+
+class AsymVisibility {
+    /**
+    * Stars should be aligned.
+   */
+    public(set) int $prop = 1;
+
+    /**
+      * Stars should be aligned.
+       */
+    protected(set) int $prop = 1;
+
+    /**
+     * Stars should be aligned.
+     */
+    private(set) int $prop = 1;
+}

src/Standards/Squiz/Tests/Commenting/DocCommentAlignmentUnitTest.inc.fixed

@@ -114,3 +114,20 @@ final class FinalClassWithFinalProp
      */
     final $property = 10;
 }
+
+class AsymVisibility {
+    /**
+     * Stars should be aligned.
+     */
+    public(set) int $prop = 1;
+
+    /**
+     * Stars should be aligned.
+     */
+    protected(set) int $prop = 1;
+
+    /**
+     * Stars should be aligned.
+     */
+    private(set) int $prop = 1;
+}

src/Standards/Squiz/Tests/Commenting/DocCommentAlignmentUnitTest.php

@@ -63,7 +63,12 @@ public function getErrorList($testFile='')
             $errors[112] = 1;
             $errors[113] = 1;
             $errors[114] = 1;
-        }
+
+            $errors[120] = 1;
+            $errors[121] = 1;
+            $errors[125] = 1;
+            $errors[126] = 1;
+        }//end if
 
         return $errors;