-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Option to ignore parse file storage #2222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@OzgeAkin How did you migrate your files from Parse's S3 to your own S3 bucket? |
|
@natanrolnik By running a script which iterates through json file to find each parse file object and uploading it to our s3 bucket. |
src/ParseServer.js
Outdated
| maxUploadSize = '20mb', | ||
| verifyUserEmails = false, | ||
| preventLoginWithUnverifiedEmail = false, | ||
| useOnlyFilesAdapter = false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: alignment
|
@OzgeAkin updated the pull request. |
|
@OzgeAkin updated the pull request. |
1 similar comment
|
@OzgeAkin updated the pull request. |
|
@OzgeAkin updated the pull request. |
|
Rather than adding a new option, what about checking for the existence of a file key? If one is not provided, we can skip the check for files on Parse.com |
|
@drew-gross That is a good suggestion. Right now the default value for fileKey is 'invalid-file-key', I could have done an if statement in FilesController that checks if the file key equals to this value. However, can you assure that this value would not change in the future? Or should i check for multiple values such as 'invalid-file-key', '', 'undefined' and etc. |
|
I'd suggest removing the default. Then if |
|
@OzgeAkin updated the pull request. |
|
@OzgeAkin updated the pull request. |
1 similar comment
|
@OzgeAkin updated the pull request. |
|
@drew-gross I made the changes according to your suggestion. Thanks. |
* flag in configurations to use only files adapter * added lib folder * remove lib * alignment edit * replace comma with semicolon * ignore parse file storage if fileKey is not provided (undefined)
* flag in configurations to use only files adapter * added lib folder * remove lib * alignment edit * replace comma with semicolon * ignore parse file storage if fileKey is not provided (undefined)
We already finished migrating files from parse S3 to our own S3 and we want to use only our file storage.
In the current version of parse server, in the filesController, it points to two of the file storage based on the file name's prefix
We would like to have an option to config the server to point only to our S3 no matter what the prefix of the file names are.
We think this is important because eventually all the parsefile will be gone.