Skip to content

Conversation

@OzgeAkin
Copy link
Contributor

@OzgeAkin OzgeAkin commented Jul 6, 2016

We already finished migrating files from parse S3 to our own S3 and we want to use only our file storage.
In the current version of parse server, in the filesController, it points to two of the file storage based on the file name's prefix

We would like to have an option to config the server to point only to our S3 no matter what the prefix of the file names are.

We think this is important because eventually all the parsefile will be gone.

@natanrolnik
Copy link
Contributor

@OzgeAkin How did you migrate your files from Parse's S3 to your own S3 bucket?

@OzgeAkin
Copy link
Contributor Author

OzgeAkin commented Jul 7, 2016

@natanrolnik By running a script which iterates through json file to find each parse file object and uploading it to our s3 bucket.

maxUploadSize = '20mb',
verifyUserEmails = false,
preventLoginWithUnverifiedEmail = false,
useOnlyFilesAdapter = false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: alignment

@ghost
Copy link

ghost commented Jul 8, 2016

@OzgeAkin updated the pull request.

@ghost
Copy link

ghost commented Jul 8, 2016

@OzgeAkin updated the pull request.

1 similar comment
@ghost
Copy link

ghost commented Jul 8, 2016

@OzgeAkin updated the pull request.

@ghost
Copy link

ghost commented Jul 8, 2016

@OzgeAkin updated the pull request.

@OzgeAkin OzgeAkin closed this Jul 8, 2016
@OzgeAkin OzgeAkin reopened this Jul 8, 2016
@drew-gross
Copy link
Contributor

Rather than adding a new option, what about checking for the existence of a file key? If one is not provided, we can skip the check for files on Parse.com

@OzgeAkin
Copy link
Contributor Author

OzgeAkin commented Jul 9, 2016

@drew-gross That is a good suggestion. Right now the default value for fileKey is 'invalid-file-key', I could have done an if statement in FilesController that checks if the file key equals to this value. However, can you assure that this value would not change in the future? Or should i check for multiple values such as 'invalid-file-key', '', 'undefined' and etc.

@drew-gross
Copy link
Contributor

I'd suggest removing the default. Then if fileKey is undefined you can skip the check.

@ghost
Copy link

ghost commented Jul 10, 2016

@OzgeAkin updated the pull request.

@ghost
Copy link

ghost commented Jul 10, 2016

@OzgeAkin updated the pull request.

1 similar comment
@ghost
Copy link

ghost commented Jul 10, 2016

@OzgeAkin updated the pull request.

@OzgeAkin
Copy link
Contributor Author

@drew-gross I made the changes according to your suggestion. Thanks.

rsouzas pushed a commit to back4app/parse-server that referenced this pull request Mar 15, 2017
* flag in configurations to use only files adapter

* added lib folder

* remove lib

* alignment edit

* replace comma with semicolon

* ignore parse file storage if fileKey is not provided (undefined)
rsouzas pushed a commit to back4app/parse-server that referenced this pull request Mar 16, 2017
* flag in configurations to use only files adapter

* added lib folder

* remove lib

* alignment edit

* replace comma with semicolon

* ignore parse file storage if fileKey is not provided (undefined)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants