Skip to content

Conversation

@kazeburo
Copy link
Contributor

@kazeburo kazeburo commented Apr 2, 2013

Module::Build 0.4004 supports test_configure. But MYMETA.json and META.json (generated by perl ./Build.PL and ./Build distmeta) does not have $meta{prereqs}{test}. They have x_test_requires.

After ./Build distmata, When I run perl ./Build.PL again. I got $meta{prereqs}{test} in MYMETA.json.
It is enough for installing prereqs modules, but confusing. I want to get $meta{prereqs}{test} in first perl ./Build.PL

This patch upgrades a metadata that created by get_metadata() to spec-2 before write meta files.

@Leont
Copy link
Member

Leont commented Apr 2, 2013

I don't think deleting x_test_requires is the right solution. We should add it correctly in the first place so it won't be added like that at all.

Something goes wrong between CPAN::Meta::Convert and Module::Build, not entirely sure what the solution is yet.

@miyagawa
Copy link
Member

miyagawa commented Apr 2, 2013

META spec 1.4 doesn't support test_requires, does it?
http://module-build.sourceforge.net/META-spec-v1.4.html

@Leont
Copy link
Member

Leont commented Apr 4, 2013

META spec 1.4 doesn't support test_requires, does it?
Indeed, but M::B seems to be inserting all prereqs into it regardless.

The core problem is that Module::Build (like MakeMaker) is Meta 1.4 on the inside. Fixing this is non-trivial.

@karenetheridge
Copy link
Member

On Thu, Apr 04, 2013 at 06:33:35AM -0700, Leon Timmermans wrote:

The core problem is that Module::Build (like MakeMaker) is Meta 1.4 on the inside. Fixing this is non-trivial.

Is anyone interested in working on this at Lancaster? :) or, at least
sketching out what is required, so that pieces can be farmed off to others?

@miyagawa
Copy link
Member

miyagawa commented Apr 4, 2013

If anyone can fix the root cause for that at QAH would be great, but @kazeburo's patch upgrades to 2.0 in-place and it works better than what we have today nonetheless.

@dagolden
Copy link

I think test_requires should get folded into build_requires, just like Module::Install did (or does?). We want to let people specify that they mean "test" for the future should META v2 ever be supported.

@Leont
Copy link
Member

Leont commented Nov 4, 2013

Please test 0.40_09, it should fix this issue.

@Leont
Copy link
Member

Leont commented Jan 16, 2014

Closed, as this this has been fixed in the 0.420X series of releases.

@Leont Leont closed this Jan 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants