Make clippy happy

Author: mejrs

examples/pyo3-pytests/src/buf_and_str.rs

@@ -14,22 +14,26 @@ impl BytesExtractor {
         BytesExtractor {}
     }
 
-    pub fn from_bytes(&mut self, bytes: &PyBytes) -> PyResult<usize> {
+    #[staticmethod]
+    pub fn from_bytes(bytes: &PyBytes) -> PyResult<usize> {
         let byte_vec: Vec<u8> = bytes.extract()?;
         Ok(byte_vec.len())
     }
 
-    pub fn from_str(&mut self, string: &PyString) -> PyResult<usize> {
+    #[staticmethod]
+    pub fn from_str(string: &PyString) -> PyResult<usize> {
         let rust_string: String = string.extract()?;
         Ok(rust_string.len())
     }
 
-    pub fn from_str_lossy(&mut self, string: &PyString) -> PyResult<usize> {
+    #[staticmethod]
+    pub fn from_str_lossy(string: &PyString) -> PyResult<usize> {
         let rust_string_lossy: String = string.to_string_lossy().to_string();
         Ok(rust_string_lossy.len())
     }
 
-    pub fn from_buffer(&mut self, buf: &PyAny) -> PyResult<usize> {
+    #[staticmethod]
+    pub fn from_buffer(buf: &PyAny) -> PyResult<usize> {
         let buf = PyBuffer::<u8>::get(buf)?;
         Ok(buf.item_count())
     }

pyo3-macros-backend/src/lib.rs

@@ -3,7 +3,6 @@
 
 #![cfg_attr(docsrs, feature(doc_cfg))]
 #![recursion_limit = "1024"]
-
 // Listed first so that macros in this module are available in the rest of the crate.
 #[macro_use]
 mod utils;

pyo3-macros-backend/src/method.rs

@@ -29,9 +29,7 @@ impl<'a> FnArg<'a> {
     /// Transforms a rust fn arg parsed with syn into a method::FnArg
     pub fn parse(arg: &'a mut syn::FnArg) -> Result<Self> {
         match arg {
-            syn::FnArg::Receiver(recv) => {
-                bail_spanned!(recv.span() => "unexpected receiver")
-            } // checked in parse_fn_type
+            syn::FnArg::Receiver(recv) => bail_spanned!(recv.span() => "unexpected receiver"), // checked in parse_fn_type
             syn::FnArg::Typed(cap) => {
                 if let syn::Type::ImplTrait(_) = &*cap.ty {
                     bail_spanned!(cap.ty.span() => IMPL_TRAIT_ERR);
@@ -101,9 +99,7 @@ impl FnType {
                 cls.expect("no class given for Fn with a \"self\" receiver"),
                 error_mode,
             ),
-            FnType::FnNew | FnType::FnStatic | FnType::ClassAttribute => {
-                quote!()
-            }
+            FnType::FnNew | FnType::FnStatic | FnType::ClassAttribute => quote!(),
             FnType::FnClass => {
                 quote! {
                     let _slf = ::pyo3::types::PyType::from_type_ptr(_py, _slf as *mut ::pyo3::ffi::PyTypeObject);
@@ -352,7 +348,8 @@ impl<'a> FnSpec<'a> {
             parse_method_receiver(first_arg)
         };
 
-        #[allow(clippy::manual_strip)] // for strip_prefix replacement supporting rust < 1.45
+        #[allow(clippy::manual_strip)]
+        // for strip_prefix replacement supporting rust < 1.45
         // strip get_ or set_
         let strip_fn_name = |prefix: &'static str| {
             let ident = name.unraw().to_string();

pyo3-macros-backend/src/params.rs

@@ -266,7 +266,7 @@ fn impl_arg_param(
         }
     };
 
-    return if let syn::Type::Reference(tref) = unwrap_ty_group(arg.optional.unwrap_or(ty)) {
+    if let syn::Type::Reference(tref) = unwrap_ty_group(arg.optional.unwrap_or(ty)) {
         let mut tref = remove_lifetime(tref);
         if let Some(cls) = self_ {
             replace_self(&mut tref.elem, cls);
@@ -298,5 +298,5 @@ fn impl_arg_param(
         Ok(quote_arg_span! {
             let #arg_name = #arg_value_or_default;
         })
-    };
+    }
 }

pyo3-macros-backend/src/pyimpl.rs

@@ -36,7 +36,7 @@ pub fn build_py_methods(
 
 pub fn impl_methods(
     ty: &syn::Type,
-    impls: &mut Vec<syn::ImplItem>,
+    impls: &mut [syn::ImplItem],
     methods_type: PyClassMethodsType,
 ) -> syn::Result<TokenStream> {
     let mut trait_impls = Vec::new();

pyo3-macros-backend/src/pymethod.rs

@@ -138,9 +138,7 @@ pub fn gen_py_method(
             cls,
             PropertyType::Function { self_type, spec },
         )?),
-        (_, FnType::FnModule) => {
-            unreachable!("methods cannot be FnModule")
-        }
+        (_, FnType::FnModule) => unreachable!("methods cannot be FnModule"),
     })
 }
 

pyo3-macros-backend/src/pyproto.rs

@@ -45,7 +45,7 @@ pub fn build_py_proto(ast: &mut syn::ItemImpl) -> syn::Result<TokenStream> {
 
 fn impl_proto_impl(
     ty: &syn::Type,
-    impls: &mut Vec<syn::ImplItem>,
+    impls: &mut [syn::ImplItem],
     proto: &defs::Proto,
 ) -> syn::Result<TokenStream> {
     let mut trait_impls = TokenStream::new();

src/conversion.rs

@@ -195,7 +195,6 @@ where
 ///         }
 ///     }
 /// }
-/// # fn main() {
 /// #     Python::with_gil(|py| {
 /// #         let v = Value::Integer(73).into_py(py);
 /// #         let v = v.extract::<i32>(py).unwrap();
@@ -206,7 +205,6 @@ where
 /// #         let v = Value::None.into_py(py);
 /// #         let v = v.extract::<Option<Vec<i32>>>(py).unwrap();
 /// #     });
-/// # }
 /// ```
 /// Python code will see this as any of the `int`, `string` or `None` objects.
 #[cfg_attr(docsrs, doc(alias = "IntoPyCallbackOutput"))]

src/ffi/pyhash.rs

@@ -14,7 +14,7 @@ extern "C" {
     pub fn _Py_HashBytes(src: *const c_void, len: Py_ssize_t) -> Py_hash_t;
 }
 
-pub const _PyHASH_MULTIPLIER: c_ulong = 1000003;
+pub const _PyHASH_MULTIPLIER: c_ulong = 1_000_003;
 
 // skipped _PyHASH_BITS
 

src/instance.rs

@@ -172,7 +172,6 @@ pub unsafe trait PyNativeType: Sized {
 /// use pyo3::prelude::*;
 /// use pyo3::types::PyDict;
 ///
-/// # fn main() {
 /// Python::with_gil(|py| {
 ///     let first: Py<PyDict> = PyDict::new(py).into();
 ///
@@ -190,7 +189,6 @@ pub unsafe trait PyNativeType: Sized {
 ///     assert_eq!(fourth.as_ptr(), fifth.as_ptr());
 ///     assert_eq!(second.as_ptr(), fourth.as_ptr());
 /// });
-/// # }
 /// ```
 ///
 /// # Preventing reference cycles
@@ -479,15 +477,13 @@ impl<T> Py<T> {
     /// use pyo3::prelude::*;
     /// use pyo3::types::PyDict;
     ///
-    /// # fn main() {
     /// Python::with_gil(|py| {
     ///     let first: Py<PyDict> = PyDict::new(py).into();
     ///     let second = Py::clone_ref(&first, py);
     ///
     ///     // Both point to the same object
     ///     assert_eq!(first.as_ptr(), second.as_ptr());
     /// });
-    /// # }
     /// ```
     #[inline]
     pub fn clone_ref(&self, py: Python) -> Py<T> {