fix: phantom ping issue

Author: QuantGeekDev

src/transports/http/server.ts

@@ -20,21 +20,13 @@ export class HttpStreamTransport extends AbstractTransport {
   private _serverConfig: any;
   private _serverSetupCallback?: (server: McpServer) => Promise<void>;
 
-  private _pingInterval?: NodeJS.Timeout;
-  private _pingTimeouts: Map<string | number, NodeJS.Timeout> = new Map();
-  private _pingFrequency: number;
-  private _pingTimeout: number;
-
   constructor(config: HttpStreamTransportConfig = {}) {
     super();
 
     this._port = config.port || 8080;
     this._endpoint = config.endpoint || '/mcp';
     this._enableJsonResponse = config.responseMode === 'batch';
 
-    this._pingFrequency = config.ping?.frequency ?? 30000;
-    this._pingTimeout = config.ping?.timeout ?? 10000;
-
     logger.debug(
       `HttpStreamTransport configured with: ${JSON.stringify({
         port: this._port,
@@ -44,10 +36,6 @@ export class HttpStreamTransport extends AbstractTransport {
         maxMessageSize: config.maxMessageSize,
         auth: config.auth ? true : false,
         cors: config.cors ? true : false,
-        ping: {
-          frequency: this._pingFrequency,
-          timeout: this._pingTimeout,
-        },
       })}`
     );
   }
@@ -97,7 +85,6 @@ export class HttpStreamTransport extends AbstractTransport {
       this._server.listen(this._port, () => {
         logger.info(`HTTP server listening on port ${this._port}, endpoint ${this._endpoint}`);
         this._isRunning = true;
-        this.startPingInterval();
         resolve();
       });
     });
@@ -202,52 +189,10 @@ export class HttpStreamTransport extends AbstractTransport {
     );
   }
 
-  private startPingInterval(): void {
-    if (this._pingFrequency > 0) {
-      logger.debug(
-        `Starting ping interval with frequency ${this._pingFrequency}ms and timeout ${this._pingTimeout}ms`
-      );
-      this._pingInterval = setInterval(() => this.sendPing(), this._pingFrequency);
-    }
-  }
-
-  private async sendPing(): Promise<void> {
-    if (!this._isRunning || Object.keys(this._transports).length === 0) {
-      return;
-    }
-
-    const pingId = `ping-${Date.now()}`;
-    const pingRequest: JSONRPCMessage = {
-      jsonrpc: '2.0' as const,
-      id: pingId,
-      method: 'ping',
-    };
-
-    logger.debug(
-      `Broadcasting ping to ${Object.keys(this._transports).length} sessions: ${JSON.stringify(pingRequest)}`
-    );
-
-    for (const [sessionId, transport] of Object.entries(this._transports)) {
-      try {
-        await transport.send(pingRequest);
-
-        const timeoutId = setTimeout(() => {
-          logger.warn(`Ping timeout for session ${sessionId}`);
-          delete this._transports[sessionId];
-          this._pingTimeouts.delete(pingId);
-        }, this._pingTimeout);
-
-        this._pingTimeouts.set(pingId, timeoutId);
-      } catch (error) {
-        logger.error(`Error sending ping to session ${sessionId}: ${error}`);
-        delete this._transports[sessionId];
-      }
-    }
-  }
-
   async send(message: JSONRPCMessage): Promise<void> {
     if (!this._isRunning) {
-      throw new Error('HttpStreamTransport not running');
+      logger.warn('Attempted to send message, but HTTP transport is not running');
+      return;
     }
 
     const activeSessions = Object.entries(this._transports);
@@ -282,16 +227,6 @@ export class HttpStreamTransport extends AbstractTransport {
       return;
     }
 
-    if (this._pingInterval) {
-      clearInterval(this._pingInterval);
-      this._pingInterval = undefined;
-    }
-
-    for (const timeout of this._pingTimeouts.values()) {
-      clearTimeout(timeout);
-    }
-    this._pingTimeouts.clear();
-
     for (const transport of Object.values(this._transports)) {
       try {
         await transport.close();

src/transports/http/types.ts

@@ -61,24 +61,6 @@ export interface HttpStreamTransportConfig {
    */
   endpoint?: string;
 
-  /**
-   * Configure ping mechanism for connection health verification
-   */
-  ping?: {
-    /**
-     * Interval in milliseconds for sending ping requests
-     * Set to 0 to disable pings
-     * Default: 30000 (30 seconds)
-     */
-    frequency?: number;
-
-    /**
-     * Timeout in milliseconds for waiting for a ping response
-     * Default: 10000 (10 seconds)
-     */
-    timeout?: number;
-  };
-
   /**
    * Response mode: stream (Server-Sent Events) or batch (JSON)
    * Defaults to 'stream'
@@ -127,8 +109,4 @@ export const DEFAULT_HTTP_STREAM_CONFIG: HttpStreamTransportConfig = {
   batchTimeout: 30000,
   maxMessageSize: 4 * 1024 * 1024,
   session: DEFAULT_SESSION_CONFIG,
-  ping: {
-    frequency: 30000,
-    timeout: 10000,
-  },
 };

tests/transports/http/server.test.ts

@@ -34,10 +34,6 @@ describe('HttpStreamTransport', () => {
         port: 9999,
         endpoint: '/custom-mcp',
         responseMode: 'batch',
-        ping: {
-          frequency: 60000,
-          timeout: 15000,
-        },
       });
 
       expect(customTransport).toBeDefined();
@@ -117,32 +113,6 @@ describe('HttpStreamTransport', () => {
   });
 
   describe('Configuration Validation', () => {
-    it('should accept valid ping configuration', () => {
-      const transportWithPing = new HttpStreamTransport({
-        port: 8080,
-        ping: {
-          frequency: 30000,
-          timeout: 10000,
-        },
-      });
-
-      expect(transportWithPing).toBeDefined();
-      expect(transportWithPing.type).toBe('http-stream');
-    });
-
-    it('should accept disabled ping configuration', () => {
-      const transportNoPing = new HttpStreamTransport({
-        port: 8080,
-        ping: {
-          frequency: 0, // Disabled
-          timeout: 10000,
-        },
-      });
-
-      expect(transportNoPing).toBeDefined();
-      expect(transportNoPing.type).toBe('http-stream');
-    });
-
     it('should handle different response modes', () => {
       const streamTransport = new HttpStreamTransport({
         responseMode: 'stream',
@@ -170,8 +140,7 @@ describe('HttpStreamTransport', () => {
 
     it('should support proper session management structure', () => {
       const serverConfig = { name: 'multi-client-server', version: '1.0.0' };
-      const setupCallback = async () => {
-      };
+      const setupCallback = async () => {};
 
       // Should accept configuration for multi-client support
       expect(() => transport.setServerConfig(serverConfig, setupCallback)).not.toThrow();
@@ -226,14 +195,12 @@ describe('HttpStreamTransport', () => {
 
   describe('Integration with Framework Pattern', () => {
     it('should follow the multi-session architecture', () => {
-
       const serverConfig = {
         name: 'http-stream-server',
         version: '1.0.0',
       };
 
-      const setupCallback = async () => {
-      };
+      const setupCallback = async () => {};
 
       // Should accept the configuration pattern used by working examples
       expect(() => transport.setServerConfig(serverConfig, setupCallback)).not.toThrow();