Skip to content

Conversation

@justsml
Copy link
Contributor

@justsml justsml commented Oct 21, 2018

Hi y'all, thanks to everyone for all the work that's gone into this library!!! 👍

Here's a summary of my progress so far:

  • Add simpler "basic" example for "Quick Start."
  • Enhance (previous) nested routing example from "Quick Start."
  • Add explainer text to examples.
  • Move Philosophy to lower in the nav.
  • Quick Start is default content.

RE: #6409

@justsml
Copy link
Contributor Author

justsml commented Oct 22, 2018

For completeness, here's the before and after screenshots:

Before

image

After

image

@justsml
Copy link
Contributor Author

justsml commented Oct 22, 2018

Thanks for the 👍 @pshrmn @timdorr

@mjackson mjackson merged commit 64b4335 into remix-run:master Oct 25, 2018
@mjackson
Copy link
Member

Thanks for the PR, @justsml! This looks great. I'll deploy it now.

@mjackson
Copy link
Member

Should deploy as soon as https://travis-ci.org/ReactTraining/react-router/builds/445992237 is finished 👍

@justsml
Copy link
Contributor Author

justsml commented Oct 25, 2018

That's great news @mjackson!!!
Thanks for the merge! 👍

@justsml justsml deleted the patch-1 branch October 25, 2018 04:21
@mjackson
Copy link
Member

Thank you for your contributions to the docs, @justsml :) A lot of people are going to benefit from the improvements you're making.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants