Skip to content

Bug: insert_content passes isWriteProtected as the partial flag, causing ‘Current ask promise was ignored’ #7648

@hannesrudolph

Description

@hannesrudolph

Deeper investigation reveals the root cause is in , not .

Summary

  • The error “Current ask promise was ignored (Add options to always approve write and execute operations #1)” is thrown by when it receives a partial/streaming update for an ask that wasn't initiated as partial. See .
  • incorrectly calls . The third argument to is the flag.
  • When is (as it is for paths under ), the call is treated as a partial update, which is not expected, causing the promise to be ignored and the error to be thrown.

Problematic Code
The issue is here:

Suggested Fix

  • The wrapper in should be used, as it correctly handles the flag as the 5th argument.
  • The calls in and should be changed to use the function, similar to how does it.
  • Example correct implementation from :

This will ensure the boolean is not misinterpreted as the flag.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Issue/PR - TriageNew issue. Needs quick review to confirm validity and assign labels.bugSomething isn't working

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions