Fix evals #7547
Merged
Fix evals #7547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| packages/ipc \ | ||
| packages/types | ||
| packages/types \ | ||
| packages/cloud |
Contributor
There was a problem hiding this comment.
Is this intentional? The line is missing a trailing backslash for consistency with the other lines in this mkdir command. Consider:
Suggested change
| packages/cloud | |
| packages/cloud \n``` | |
| This would maintain consistency with the formatting pattern used for other directories. |
| packages/ipc \ | ||
| packages/telemetry \ | ||
| packages/types \ | ||
| packages/cloud \ |
Contributor
There was a problem hiding this comment.
Good addition here. The cloud package is properly included with the trailing backslash, maintaining consistency with the rest of the mkdir command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add
cloudpackage to Docker build process inDockerfile.runnerandDockerfile.web.packages/clouddirectory creation andpackage.jsoncopy inDockerfile.runnerandDockerfile.web.cloudpackage is included in the build process for both runner and web environments.This description was created by
for a87f011. You can customize this summary. It will automatically update as commits are pushed.