bug: Incorrect copy for "Run" command when approving execution #8179

brunobergher · 2025-09-19T15:28:53Z

This was happening because the incorrect key was being used in two places.

Important

Fixes incorrect text for 'Run' command during execution approval by updating translation keys and values in ChatRow.tsx and multiple chat.json files.

Behavior:
- Fixes incorrect text for 'Run' command in ChatRow.tsx by changing the translation key from chat:runCommand.title to chat:commandExecution.running.
Translations:
- Updates running translation in chat.json files for multiple locales (e.g., ca, de, en, es, fr, hi, id, it, ja, ko, nl, pl, ru, tr, vi, zh-CN, zh-TW) to correct the text for command execution status.
- Corrects runCommand.title translation in en/chat.json from "Command" to "Run".

^{This description was created by}^{for a400916. You can customize this summary. It will automatically update as commits are pushed.}

mrubens · 2025-09-19T15:32:51Z

webview-ui/src/i18n/locales/es/chat.json

 	"commandExecution": {
 		"running": "Corriendo",
 		"abort": "Abortar",
+		"running": "Ejecutando",


It looks like it duplicated the "running" key here and maybe didn't update the runCommand.title?

ellipsis-dev · 2025-09-19T15:33:06Z

webview-ui/src/i18n/locales/ca/chat.json

 	"commandExecution": {
 		"running": "Corrent",
 		"abort": "Avortar",
+		"running": "En execució",


Duplicate key 'running' found in the same JSON object. This may result in one of the values being ignored. Please remove or rename one of them to ensure the intended translation is used.

Suggested change

"running": "En execució",

ellipsis-dev · 2025-09-19T15:33:06Z

webview-ui/src/i18n/locales/de/chat.json

 	"commandExecution": {
 		"running": "Wird ausgeführt",
 		"abort": "Abbrechen",
+		"running": "Wird ausgeführt",


Duplicate key 'running' found on line 208. This key already exists on line 206 with the same value. Please remove or modify the duplicate to avoid potential issues.

Suggested change

"running": "Wird ausgeführt",

ellipsis-dev · 2025-09-19T15:33:06Z

webview-ui/src/i18n/locales/es/chat.json

 	},
 	"commandOutput": "Salida del comando",
 	"commandExecution": {
 		"running": "Corriendo",


Note: There is a duplicate key 'running' in this JSON object (lines 206 and 208). Please verify if having two entries is intentional or if one of them should be removed/renamed.

Suggested change

"running": "Corriendo",

ellipsis-dev · 2025-09-19T15:33:06Z

webview-ui/src/i18n/locales/fr/chat.json

 	"commandExecution": {
 		"running": "En cours",
 		"abort": "Abandonner",
+		"running": "En cours d'exécution",


Typographical note: There appears to be a duplicate key 'running' in this JSON object. This might be a typo or unintended duplication. Please verify if both entries are needed or consider removing/renaming one of them.

Suggested change

"running": "En cours d'exécution",

ellipsis-dev · 2025-09-19T15:33:06Z

webview-ui/src/i18n/locales/hi/chat.json

 	"commandExecution": {
 		"running": "चल रहा है",
 		"abort": "रद्द करें",
+		"running": "चल रहा है",


Typo: The key 'running' is duplicated in this JSON object. Likely one of them was mistakenly added. Please remove or correct the duplicate entry.

Suggested change

"running": "चल रहा है",

ellipsis-dev · 2025-09-19T15:33:07Z

webview-ui/src/i18n/locales/ru/chat.json

 	"commandExecution": {
 		"running": "Выполняется",
 		"abort": "Прервать",
+		"running": "Выполняется",


There's a duplicate translation key "running" added in this diff (line 203). JSON objects shouldn't have duplicate keys as it can lead to unexpected behavior. Please remove one of the duplicate entries.

Suggested change

"running": "Выполняется",

^{This comment was generated because it violated a code review rule: irule_PTI8rjtnhwrWq6jS.}

ellipsis-dev · 2025-09-19T15:33:07Z

webview-ui/src/i18n/locales/tr/chat.json

 	"commandExecution": {
 		"running": "Çalışıyor",
 		"abort": "İptal Et",
+		"running": "Çalışıyor",


Typographical issue: Duplicate key 'running' is present in the 'commandExecution' object. Please remove the duplicate to avoid potential conflicts.

Suggested change

"running": "Çalışıyor",

ellipsis-dev · 2025-09-19T15:33:08Z

webview-ui/src/i18n/locales/vi/chat.json

 	"commandExecution": {
 		"running": "Đang chạy",
 		"abort": "Hủy bỏ",
+		"running": "Đang chạy",


There is a duplicate key "running" in this JSON object. Please remove or consolidate the duplicate entry to avoid unintended behavior.

Suggested change

"running": "Đang chạy",

ellipsis-dev · 2025-09-19T15:33:08Z

webview-ui/src/i18n/locales/zh-CN/chat.json

 	"commandExecution": {
 		"running": "正在运行",
 		"abort": "中止",
+		"running": "运行中",


There's a duplicate key 'running' in this JSON object. This is likely a copy-paste error. Consider removing or renaming one of the 'running' keys to avoid ambiguity.

Suggested change

"running": "运行中",

ellipsis-dev · 2025-09-19T15:33:08Z

webview-ui/src/i18n/locales/zh-TW/chat.json

 	"commandExecution": {
 		"running": "正在執行",
 		"abort": "中止",
+		"running": "執行中",


There is a duplicate key 'running' in this JSON object. In JSON, keys must be unique, so please remove or update the redundant entry instead of adding another 'running' key.

Suggested change

"running": "執行中",

roomote

Thank you for your contribution! I've reviewed the changes and found critical issues that need attention.

roomote · 2025-09-19T15:33:55Z

webview-ui/src/i18n/locales/ca/chat.json

 	"commandExecution": {
 		"running": "Corrent",
 		"abort": "Avortar",
+		"running": "En execució",


This creates a duplicate "running" key in the commandExecution object. JSON doesn't allow duplicate keys - this will cause parsing errors or unexpected behavior.

You should remove the existing "running" key on line 206 before adding the new one, or update the existing key instead of adding a duplicate.

roomote · 2025-09-19T15:33:55Z

webview-ui/src/i18n/locales/de/chat.json

 	"commandExecution": {
 		"running": "Wird ausgeführt",
 		"abort": "Abbrechen",
+		"running": "Wird ausgeführt",


Duplicate "running" key detected. Please remove the duplicate to avoid JSON parsing issues.

roomote · 2025-09-19T15:33:55Z

webview-ui/src/i18n/locales/es/chat.json

 	"commandExecution": {
 		"running": "Corriendo",
 		"abort": "Abortar",
+		"running": "Ejecutando",


Duplicate "running" key detected. Also, is the translation change intentional? "Corriendo" vs "Ejecutando" have slightly different meanings.

webview-ui/src/components/chat/ChatRow.tsx

daniel-lxs

Looks good!

brunobergher added 2 commits September 19, 2025 16:19

Fixes use of duplicate i18n key

f74bb4f

Translations

7a04666

brunobergher requested review from cte, jr and mrubens as code owners September 19, 2025 15:28

github-project-automation bot added this to Roo Code Roadmap Sep 19, 2025

github-project-automation bot moved this to Triage in Roo Code Roadmap Sep 19, 2025

github-project-automation bot added this to Roo Code Roadmap Sep 19, 2025

github-project-automation bot moved this to New in Roo Code Roadmap Sep 19, 2025

dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Sep 19, 2025

hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Sep 19, 2025

mrubens reviewed Sep 19, 2025

View reviewed changes

ellipsis-dev bot reviewed Sep 19, 2025

View reviewed changes

roomote bot reviewed Sep 19, 2025

View reviewed changes

daniel-lxs moved this from Triage to PR [Draft / In Progress] in Roo Code Roadmap Sep 19, 2025

Removes duplicate keys (and ensures correct translations)

a400916

hannesrudolph added PR - Draft / In Progress and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Sep 19, 2025

daniel-lxs approved these changes Sep 19, 2025

View reviewed changes

dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 19, 2025

daniel-lxs moved this from PR [Draft / In Progress] to PR [Needs Review] in Roo Code Roadmap Sep 19, 2025

hannesrudolph added PR - Needs Review and removed PR - Draft / In Progress labels Sep 19, 2025

mrubens merged commit 07684c0 into main Sep 19, 2025
14 of 15 checks passed

github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Sep 19, 2025

github-project-automation bot moved this from New to Done in Roo Code Roadmap Sep 19, 2025

mrubens deleted the bug/run-command branch September 19, 2025 18:40

bug: Incorrect copy for "Run" command when approving execution #8179

bug: Incorrect copy for "Run" command when approving execution #8179

Uh oh!

Conversation

brunobergher commented Sep 19, 2025 • edited by ellipsis-dev bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mrubens Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

brunobergher Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

ellipsis-dev bot Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

ellipsis-dev bot Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

ellipsis-dev bot Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

ellipsis-dev bot Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

ellipsis-dev bot Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

ellipsis-dev bot Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

ellipsis-dev bot Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

ellipsis-dev bot Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

ellipsis-dev bot Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

ellipsis-dev bot Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

roomote bot left a comment

Choose a reason for hiding this comment

Uh oh!

roomote bot Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

roomote bot Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

roomote bot Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

daniel-lxs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

brunobergher commented Sep 19, 2025 •

edited by ellipsis-dev bot

Loading