Skip to content

Commit b269da3

Browse files
authored
fix(AnalyticalTable): remove double scrollbars on windows (#283)
1 parent bdf2c95 commit b269da3

File tree

3 files changed

+11
-1
lines changed

3 files changed

+11
-1
lines changed

packages/main/src/components/AnalyticalTable/AnayticalTable.jss.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ const styles = ({ parameters }: JSSTheme) => ({
3737
tbody: {
3838
position: 'relative',
3939
zIndex: 0,
40-
overflowX: 'auto',
4140
backgroundColor: parameters.sapUiListBackground
4241
},
4342
alternateRowColor: {
@@ -99,6 +98,10 @@ const styles = ({ parameters }: JSSTheme) => ({
9998
whiteSpace: 'nowrap',
10099
alignItems: 'center'
101100
},
101+
virtualTableBody: {
102+
overflowX: 'hidden !important',
103+
overflowY: 'auto !important'
104+
},
102105
noDataContainer: {
103106
display: 'flex',
104107
justifyContent: 'center',

packages/main/src/components/AnalyticalTable/__snapshots__/AnalyticalTable.test.tsx.snap

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -296,6 +296,7 @@ exports[`AnalyticalTable Alternate Row Color 1`] = `
296296
</div>
297297
</header>
298298
<div
299+
class="AnalyticalTable--virtualTableBody-"
299300
style="position: relative; height: 220px; width: 240px; overflow: auto; will-change: transform; direction: ltr;"
300301
>
301302
<div
@@ -769,6 +770,7 @@ exports[`AnalyticalTable Loading - Loader 1`] = `
769770
</div>
770771
</header>
771772
<div
773+
class="AnalyticalTable--virtualTableBody-"
772774
style="position: relative; height: 220px; width: 240px; overflow: auto; will-change: transform; direction: ltr;"
773775
>
774776
<div
@@ -1854,6 +1856,7 @@ exports[`AnalyticalTable Tree Table 1`] = `
18541856
</div>
18551857
</header>
18561858
<div
1859+
class="AnalyticalTable--virtualTableBody-"
18571860
style="position: relative; height: 220px; width: 240px; overflow: auto; will-change: transform; direction: ltr;"
18581861
>
18591862
<div
@@ -2356,6 +2359,7 @@ exports[`AnalyticalTable custom row height 1`] = `
23562359
</div>
23572360
</header>
23582361
<div
2362+
class="AnalyticalTable--virtualTableBody-"
23592363
style="position: relative; height: 300px; width: 240px; overflow: auto; will-change: transform; direction: ltr;"
23602364
>
23612365
<div
@@ -3135,6 +3139,7 @@ exports[`AnalyticalTable test Asc desc 1`] = `
31353139
</div>
31363140
</header>
31373141
<div
3142+
class="AnalyticalTable--virtualTableBody-"
31383143
style="position: relative; height: 220px; width: 240px; overflow: auto; will-change: transform; direction: ltr;"
31393144
>
31403145
<div
@@ -3608,6 +3613,7 @@ exports[`AnalyticalTable test drag and drop of a draggable column 1`] = `
36083613
</div>
36093614
</header>
36103615
<div
3616+
class="AnalyticalTable--virtualTableBody-"
36113617
style="position: relative; height: 220px; width: 240px; overflow: auto; will-change: transform; direction: ltr;"
36123618
>
36133619
<div

packages/main/src/components/AnalyticalTable/virtualization/VirtualTableBody.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@ export const VirtualTableBody = (props) => {
7979

8080
return (
8181
<FixedSizeList
82+
className={classes.virtualTableBody}
8283
ref={reactWindowRef}
8384
height={tableBodyHeight}
8485
width={totalColumnsWidth}

0 commit comments

Comments
 (0)