From 3dda7afc7c7448c7bfb1551b79d242d044a88b3a Mon Sep 17 00:00:00 2001 From: "aden.chen" Date: Mon, 12 May 2025 10:37:25 +0800 Subject: [PATCH 1/3] Add null-check for `agent` in `StreamingLogHook` --- src/Plugins/BotSharp.Plugin.ChatHub/Hooks/StreamingLogHook.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Plugins/BotSharp.Plugin.ChatHub/Hooks/StreamingLogHook.cs b/src/Plugins/BotSharp.Plugin.ChatHub/Hooks/StreamingLogHook.cs index 720f3fd0a..2bc9c9e69 100644 --- a/src/Plugins/BotSharp.Plugin.ChatHub/Hooks/StreamingLogHook.cs +++ b/src/Plugins/BotSharp.Plugin.ChatHub/Hooks/StreamingLogHook.cs @@ -293,7 +293,7 @@ public override async Task OnBreakpointUpdated(string conversationId, bool reset var routing = _services.GetRequiredService(); var agentId = routing.Context.GetCurrentAgentId(); var agent = await _agentService.GetAgent(agentId); - + if (agent == null) return; var input = new ContentLogInputModel() { Name = agent.Name, From 1de8953404f18c2fef2af889bca0f343816f393c Mon Sep 17 00:00:00 2001 From: "aden.chen" Date: Thu, 15 May 2025 09:57:16 +0800 Subject: [PATCH 2/3] Enhance Twilio hook execution with conditional logic --- .../Controllers/TwilioRecordController.cs | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/Plugins/BotSharp.Plugin.Twilio/Controllers/TwilioRecordController.cs b/src/Plugins/BotSharp.Plugin.Twilio/Controllers/TwilioRecordController.cs index 4e4b1c751..8bc26a8e9 100644 --- a/src/Plugins/BotSharp.Plugin.Twilio/Controllers/TwilioRecordController.cs +++ b/src/Plugins/BotSharp.Plugin.Twilio/Controllers/TwilioRecordController.cs @@ -1,3 +1,4 @@ +using BotSharp.Abstraction.Infrastructures; using BotSharp.Core.Infrastructures; using BotSharp.Plugin.Twilio.Interfaces; using BotSharp.Plugin.Twilio.Models; @@ -36,7 +37,11 @@ public async Task PhoneRecordingStatus(ConversationalVoiceRequest convService.SaveStates(); // recording completed - await HookEmitter.Emit(_services, x => x.OnRecordingCompleted(request)); + var emitOptions = new HookEmitOption + { + ShouldExecute = hook => hook.IsMatch(request) + }; + await HookEmitter.Emit(_services, x => x.OnRecordingCompleted(request), emitOptions); } else { From 91cd150862d9a009c22897100d3335323446c105 Mon Sep 17 00:00:00 2001 From: "aden.chen" Date: Thu, 15 May 2025 10:00:28 +0800 Subject: [PATCH 3/3] Revert "Add null-check for `agent` in `StreamingLogHook`" This reverts commit 3dda7afc7c7448c7bfb1551b79d242d044a88b3a. --- src/Plugins/BotSharp.Plugin.ChatHub/Hooks/StreamingLogHook.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Plugins/BotSharp.Plugin.ChatHub/Hooks/StreamingLogHook.cs b/src/Plugins/BotSharp.Plugin.ChatHub/Hooks/StreamingLogHook.cs index 2bc9c9e69..720f3fd0a 100644 --- a/src/Plugins/BotSharp.Plugin.ChatHub/Hooks/StreamingLogHook.cs +++ b/src/Plugins/BotSharp.Plugin.ChatHub/Hooks/StreamingLogHook.cs @@ -293,7 +293,7 @@ public override async Task OnBreakpointUpdated(string conversationId, bool reset var routing = _services.GetRequiredService(); var agentId = routing.Context.GetCurrentAgentId(); var agent = await _agentService.GetAgent(agentId); - if (agent == null) return; + var input = new ContentLogInputModel() { Name = agent.Name,