Skip to content

Commit 39d8253

Browse files
committed
Make iris-grib optional for tests.
1 parent 057c427 commit 39d8253

File tree

3 files changed

+20
-11
lines changed

3 files changed

+20
-11
lines changed

lib/iris/tests/integration/netcdf/test_load_managed_attributes.py

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,15 @@
77
# Annoyingly, this import is *not* redundant, as pytest import fails without it.
88
import warnings
99

10-
import iris_grib # noqa: F401
11-
from iris_grib.grib_phenom_translation._gribcode import (
12-
GenericConcreteGRIBCode,
13-
GRIBCode,
14-
)
10+
try:
11+
import iris_grib # noqa: F401
12+
from iris_grib.grib_phenom_translation._gribcode import (
13+
GenericConcreteGRIBCode,
14+
GRIBCode,
15+
)
16+
except ImportError:
17+
iris_grib = None
18+
1519
import numpy as np
1620
import pytest
1721

@@ -178,6 +182,7 @@ def test_tuple_value__fail(self):
178182
assert result == ("[2", "3", "7]")
179183

180184

185+
@pytest.mark.skipif(iris_grib is None, reason="iris_grib is not available")
181186
class TestGribParam(LoadTestCommon):
182187
def _check_load(self, value):
183188
return self._check_load_inner("GRIB_PARAM", "GRIB_PARAM", value)

lib/iris/tests/integration/netcdf/test_save_managed_attributes.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,12 @@
44
# See LICENSE in the root of the repository for full licensing details.
55
"""Integration tests for netcdf saving of attributes with "special" handling."""
66

7-
# Unfortunately not redundant since pytest fails to import iris_grib without it.
8-
import iris_grib # noqa: F401
9-
from iris_grib.grib_phenom_translation._gribcode import GRIBCode
7+
try:
8+
import iris_grib
9+
from iris_grib.grib_phenom_translation._gribcode import GRIBCode
10+
except ImportError:
11+
iris_grib = None
12+
1013
import pytest
1114

1215
import iris
@@ -127,6 +130,7 @@ def test_none_object(self):
127130
assert result == "None"
128131

129132

133+
@pytest.mark.skipif(iris_grib is None, reason="iris_grib is not available")
130134
class TestGribParam(SaveTestCommon):
131135
def _check_save(self, value):
132136
return self._check_save_inner("GRIB_PARAM", "GRIB_PARAM", value)

lib/iris/tests/unit/fileformats/netcdf/attribute_handlers/test_GribParamHandler.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,14 @@
44
# See LICENSE in the root of the repository for full licensing details.
55
"""Unit tests for :class:`iris.fileformats.netcdf._attribute_handlers.StashHandler`."""
66

7-
# Unfortunately not redundant since pytest fails to import iris_grib without it.
8-
import iris_grib # noqa: F401
7+
import pytest
8+
9+
iris_grib = pytest.importorskip("iris_grib")
910
from iris_grib.grib_phenom_translation._gribcode import (
1011
GenericConcreteGRIBCode,
1112
GRIBCode,
1213
)
1314
import numpy as np
14-
import pytest
1515

1616
from iris.fileformats.netcdf._attribute_handlers import ATTRIBUTE_HANDLERS
1717

0 commit comments

Comments
 (0)