Skip to content

Conversation

@trexfeathers
Copy link
Contributor

🚀 Pull Request

Description

Closes #6052.


Consult Iris pull request check list


Add any of the below labels to trigger actions on this PR:

  • benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts

@trexfeathers
Copy link
Contributor Author

I have pushed up the rename commit on its own to hopefully demonstrate that everything passes 🤞

I will then push up another commit that adds a placeholder Mesh class and makes MeshXY a subclass of that.

@codecov
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.76%. Comparing base (c06bf55) to head (92360a7).
Report is 61 commits behind head on main.

Files with missing lines Patch % Lines
lib/iris/experimental/ugrid/mesh.py 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6056      +/-   ##
==========================================
- Coverage   89.76%   89.76%   -0.01%     
==========================================
  Files          90       90              
  Lines       22991    22996       +5     
  Branches     5031     5032       +1     
==========================================
+ Hits        20639    20642       +3     
- Misses       1621     1623       +2     
  Partials      731      731              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trexfeathers trexfeathers marked this pull request as ready for review July 17, 2024 14:48
Copy link
Contributor

@HGWright HGWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @trexfeathers for this, definitely makes this clearer going forward.

@HGWright HGWright enabled auto-merge (squash) July 19, 2024 12:36
@HGWright HGWright merged commit bd66de9 into SciTools:main Jul 19, 2024
@trexfeathers
Copy link
Contributor Author

Thanks @HGWright!

stephenworsley added a commit to stephenworsley/iris that referenced this pull request Jul 19, 2024
* main:
  Rename `Mesh` to `MeshXY` (SciTools#6056)
  Bump scitools/workflows from 2024.07.2 to 2024.07.3 (SciTools#6063)

# Conflicts:
#	docs/src/whatsnew/latest.rst
tkknight added a commit to tkknight/iris that referenced this pull request Jul 21, 2024
* upstream/main:
  Updated environment lockfiles (SciTools#6029)
  Pin matplotlib != 3.9.1 (SciTools#6065)
  add location argument to mesh.coords (SciTools#6055)
  Doctest compatibility with GeoVista v0.5. (SciTools#6064)
  Rename `Mesh` to `MeshXY` (SciTools#6056)
  Bump scitools/workflows from 2024.07.2 to 2024.07.3 (SciTools#6063)
@trexfeathers trexfeathers deleted the mesh_xy branch August 22, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor Mesh to MeshXY

2 participants