Store positionList.contains result in temp variable in #_updatePositionList

cgewecke · cgewecke · commit 2596d7b2e5d7 · 2021-12-10T14:19:38.000-08:00
diff --git a/contracts/protocol/modules/PerpV2LeverageModule.sol b/contracts/protocol/modules/PerpV2LeverageModule.sol
@@ -1124,10 +1124,11 @@ contract PerpV2LeverageModule is ModuleBase, ReentrancyGuard, Ownable, IModuleIs
     function _updatePositionList(ISetToken _setToken, address _baseToken) internal {
         int256 baseBalance = perpAccountBalance.getBase(address(_setToken), _baseToken);
         address[] memory positionList = positions[_setToken];
+        bool hasBaseToken = positionList.contains(_baseToken);
 
-        if (positionList.contains(_baseToken) && baseBalance == 0) {
+        if (hasBaseToken && baseBalance == 0) {
             positions[_setToken].removeStorage(_baseToken);
-        }  else if (!positionList.contains(_baseToken)) {
+        } else if (!hasBaseToken) {
             positions[_setToken].push(_baseToken);
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -1124,10 +1124,11 @@ contract PerpV2LeverageModule is ModuleBase, ReentrancyGuard, Ownable, IModuleIs`
`1124`	`1124`	`function _updatePositionList(ISetToken _setToken, address _baseToken) internal {`
`1125`	`1125`	`int256 baseBalance = perpAccountBalance.getBase(address(_setToken), _baseToken);`
`1126`	`1126`	`address[] memory positionList = positions[_setToken];`
	`1127`	`+ bool hasBaseToken = positionList.contains(_baseToken);`
`1127`	`1128`
`1128`		`- if (positionList.contains(_baseToken) && baseBalance == 0) {`
	`1129`	`+ if (hasBaseToken && baseBalance == 0) {`
`1129`	`1130`	`positions[_setToken].removeStorage(_baseToken);`
`1130`		`- } else if (!positionList.contains(_baseToken)) {`
	`1131`	`+ } else if (!hasBaseToken) {`
`1131`	`1132`	`positions[_setToken].push(_baseToken);`
`1132`	`1133`	`}`
`1133`	`1134`	`}`